[Intel-gfx] [PATCH] drm/malidp: Don't call drm_crtc_vblank_off on unbind

[Liviu Dudau]

Hi Daniel,

On Tue, Jun 02, 2020 at 11:55:05AM +0200, Daniel Vetter wrote:
> This is already done as part of the drm_atomic_helper_shutdown(),
> and in that case only for the crtc which are actually on.
> 
> v2: I overlooked that malidp also needs to have it's interrupt shut
> down reordered.

Got confused by the subject not having any version of the patch, so I've
acked the other one, but this is the one I've meant to Ack.

So, Acked-by: Liviu Dudau <liviu.dudau at arm.com>

Best regards,
Liviu

> 
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> Cc: Liviu Dudau <liviu.dudau at arm.com>
> Cc: Brian Starkey <brian.starkey at arm.com>
> ---
>  drivers/gpu/drm/arm/malidp_drv.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
> index 02904392e370..cdb817a7c611 100644
> --- a/drivers/gpu/drm/arm/malidp_drv.c
> +++ b/drivers/gpu/drm/arm/malidp_drv.c
> @@ -928,11 +928,10 @@ static void malidp_unbind(struct device *dev)
>  	drm_dev_unregister(drm);
>  	drm_kms_helper_poll_fini(drm);
>  	pm_runtime_get_sync(dev);
> -	drm_crtc_vblank_off(&malidp->crtc);
> +	drm_atomic_helper_shutdown(drm);
>  	malidp_se_irq_fini(hwdev);
>  	malidp_de_irq_fini(hwdev);
>  	drm->irq_enabled = false;
> -	drm_atomic_helper_shutdown(drm);
>  	component_unbind_all(dev, drm);
>  	of_node_put(malidp->crtc.port);
>  	malidp->crtc.port = NULL;
> -- 
> 2.26.2
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯