[Intel-gfx] [PATCH] drm/i915/dsi: Dont forget to clean up the connector on error (v2)

[Souza, Jose]

On Fri, 2020-05-22 at 13:26 -0700, Vivek Kasireddy wrote:
> If an error is encountered during the DSI initialization setup, the
> drm connector object also needs to be cleaned up along with the encoder.
> The error can happen due to a missing mode in the VBT or for other
> reasons.
> 
> v2: Rephrase the commit message to make it more clear.
> 

Reviewed-by: José Roberto de Souza <jose.souza at intel.com>

> Cc: Jani Nikula <jani.nikula at intel.com>
> Cc: Vandita Kulkarni <vandita.kulkarni at intel.com>
> Signed-off-by: Vivek Kasireddy <vivek.kasireddy at intel.com>
> ---
>  drivers/gpu/drm/i915/display/icl_dsi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
> index 4fec5bd64920..f93f72463df5 100644
> --- a/drivers/gpu/drm/i915/display/icl_dsi.c
> +++ b/drivers/gpu/drm/i915/display/icl_dsi.c
> @@ -1954,6 +1954,7 @@ void icl_dsi_init(struct drm_i915_private *dev_priv)
>  	return;
>  
>  err:
> +	drm_connector_cleanup(connector);
>  	drm_encoder_cleanup(&encoder->base);
>  	kfree(intel_dsi);
>  	kfree(intel_connector);