[Intel-gfx] [PATCH] drm/i915: Restore DP-E to VBT mapping table

Chris Wilson chris at chris-wilson.co.uk
Sat Jun 6 08:58:39 UTC 2020


Quoting Matt Roper (2020-06-06 04:18:03)
> We accidentally dropped matching for DVO_PORT_DPE from the VBT mapping
> table when we refactored the function.  Restore it.
> 
> Fixes: 4628142aeccc ("drm/i915/rkl: provide port/phy mapping for vbt")
> Cc: Lucas De Marchi <lucas.demarchi at intel.com>
> Cc: Matt Roper <matthew.d.roper at intel.com>
> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Matt Roper <matthew.d.roper at intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_bios.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index 4f1a72a90b8f..c974c716f859 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -1650,7 +1650,7 @@ static enum port dvo_port_to_port(struct drm_i915_private *dev_priv,
>                 [PORT_B] = { DVO_PORT_HDMIB, DVO_PORT_DPB, -1 },
>                 [PORT_C] = { DVO_PORT_HDMIC, DVO_PORT_DPC, -1 },
>                 [PORT_D] = { DVO_PORT_HDMID, DVO_PORT_DPD, -1 },
> -               [PORT_E] = { DVO_PORT_CRT, DVO_PORT_HDMIE, -1 },
> +               [PORT_E] = { DVO_PORT_HDMIE, DVO_PORT_DPE, DVO_PORT_CRT },

Ah, yes. That was an easy to overlook change in the table,
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Is there a way we can compute a HW coverage matrix for this table? And
see if we need to get more machines/connectors for CI?
-Chris


More information about the Intel-gfx mailing list