[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/psr: Program default IO buffer Wake and Fast Wake (rev3)

Patchwork patchwork at emeril.freedesktop.org
Sun Jun 7 14:20:53 UTC 2020


== Series Details ==

Series: drm/i915/psr: Program default IO buffer Wake and Fast Wake (rev3)
URL   : https://patchwork.freedesktop.org/series/78019/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
ffef3ca6c982 drm/i915/psr: Program default IO buffer Wake and Fast Wake
-:89: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'lines' may be better as '(lines)' to avoid precedence issues
#89: FILE: drivers/gpu/drm/i915/i915_reg.h:4526:
+#define   EDP_PSR2_IO_BUFFER_WAKE(lines)	((EDP_PSR2_IO_BUFFER_WAKE_MAX_LINES - lines) << 13)

-:92: WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#92: FILE: drivers/gpu/drm/i915/i915_reg.h:4529:
+#define   TGL_EDP_PSR2_IO_BUFFER_WAKE(lines)	((lines - TGL_EDP_PSR2_IO_BUFFER_WAKE_MIN_LINES) << 13)

-:92: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'lines' may be better as '(lines)' to avoid precedence issues
#92: FILE: drivers/gpu/drm/i915/i915_reg.h:4529:
+#define   TGL_EDP_PSR2_IO_BUFFER_WAKE(lines)	((lines - TGL_EDP_PSR2_IO_BUFFER_WAKE_MIN_LINES) << 13)

-:95: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'lines' may be better as '(lines)' to avoid precedence issues
#95: FILE: drivers/gpu/drm/i915/i915_reg.h:4532:
+#define   EDP_PSR2_FAST_WAKE(lines)		((EDP_PSR2_FAST_WAKE_MAX_LINES - lines) << 11)

-:98: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'lines' may be better as '(lines)' to avoid precedence issues
#98: FILE: drivers/gpu/drm/i915/i915_reg.h:4535:
+#define   TGL_EDP_PSR2_FAST_WAKE(lines)		((lines - TGL_EDP_PSR2_FAST_WAKE_MIN_LINES) << 10)

total: 0 errors, 1 warnings, 4 checks, 80 lines checked



More information about the Intel-gfx mailing list