[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API

Patchwork patchwork at emeril.freedesktop.org
Sun Jun 7 18:28:13 UTC 2020


== Series Details ==

Series: pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API
URL   : https://patchwork.freedesktop.org/series/78089/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
e5cf553c0dcc ACPI / LPSS: Resume Cherry Trail PWM controller in no-irq phase
e4c217421240 ACPI / LPSS: Save Cherry Trail PWM ctx registers only once (at activation)
50130652086f pwm: lpss: Add range limit check for the base_unit register value
cb9922913f55 pwm: lpss: Fix off by one error in base_unit math in pwm_lpss_prepare()
dba8a9e355db pwm: lpss: Set SW_UPDATE bit when enabling the PWM
-:78: CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#78: FILE: drivers/pwm/pwm-lpss.c:149:
+					 lpwm->info->bypass == false);

total: 0 errors, 0 warnings, 1 checks, 36 lines checked
84fd73d0b37e pwm: crc: Fix period / duty_cycle times being off by a factor of 256
9e2eaeacdf15 pwm: crc: Fix off-by-one error in the clock-divider calculations
8b1bbb8e9bc0 pwm: crc: Fix period changes not having any effect
a08d7c7752b8 pwm: crc: Enable/disable PWM output on enable/disable
989f50988bff pwm: crc: Implement apply() method to support the new atomic PWM API
2c6d747e89fe pwm: crc: Implement get_state() method
-:20: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#20: FILE: drivers/pwm/pwm-crc.c:118:
+static void crc_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm,
+			       struct pwm_state *state)

total: 0 errors, 0 warnings, 1 checks, 37 lines checked
13ddb5bbc283 drm/i915: panel: Add get_vbt_pwm_freq() helper
a5b8e319f197 drm/i915: panel: Honor the VBT PWM frequency for devs with an external PWM controller
61594a403a5c drm/i915: panel: Honor the VBT PWM min setting for devs with an external PWM controller
dc3969b82041 drm/i915: panel: Use atomic PWM API for devs with an external PWM controller



More information about the Intel-gfx mailing list