[Intel-gfx] [PATCH 06/12] drm/i915/fbc: Don't clear busy_bits for origin==GTT

[Souza, Jose]

On Wed, 2020-04-29 at 13:10 +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> The hardware host tracking won't nuke the entire cfb (unless the
> entire fb is written through the gtt) so don't clear the busy_bits
> for gtt tracking.
> 
> Not that it really matters anymore since we've lost ORIGIN_GTT usage
> everywhere.

Maybe drop it then? But for now this change looks good.

Reviewed-by: José Roberto de Souza <jose.souza at intel.com>

> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_fbc.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c
> index 983224e07eaf..56eeafa645de 100644
> --- a/drivers/gpu/drm/i915/display/intel_fbc.c
> +++ b/drivers/gpu/drm/i915/display/intel_fbc.c
> @@ -1107,11 +1107,19 @@ void intel_fbc_flush(struct drm_i915_private *dev_priv,
>  	if (!HAS_FBC(dev_priv))
>  		return;
>  
> +	/*
> +	 * GTT tracking does not nuke the entire cfb
> +	 * so don't clear busy_bits set for some other
> +	 * reason.
> +	 */
> +	if (origin == ORIGIN_GTT)
> +		return;
> +
>  	mutex_lock(&fbc->lock);
>  
>  	fbc->busy_bits &= ~frontbuffer_bits;
>  
> -	if (origin == ORIGIN_GTT || origin == ORIGIN_FLIP)
> +	if (origin == ORIGIN_FLIP)
>  		goto out;
>  
>  	if (!fbc->busy_bits && fbc->crtc &&