[Intel-gfx] [PATCH 14/22] dma-buf: Prettify typecasts for dma-fence-chain

Mika Kuoppala mika.kuoppala at linux.intel.com
Mon Mar 2 16:11:28 UTC 2020


Chris Wilson <chris at chris-wilson.co.uk> writes:

> Inside dma-fence-chain, we use a cmpxchg on an RCU-protected pointer. To
> avoid the sparse warning for using the RCU pointer directly, we have to
> cast away the __rcu annotation. However, we don't need to use void*
> everywhere and can stick to the dma_fence*.

Prolly just my english but
s/everywhere/anywhere.

Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>

>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  drivers/dma-buf/dma-fence-chain.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma-buf/dma-fence-chain.c b/drivers/dma-buf/dma-fence-chain.c
> index 44a741677d25..3d123502ff12 100644
> --- a/drivers/dma-buf/dma-fence-chain.c
> +++ b/drivers/dma-buf/dma-fence-chain.c
> @@ -62,7 +62,8 @@ struct dma_fence *dma_fence_chain_walk(struct dma_fence *fence)
>  			replacement = NULL;
>  		}
>  
> -		tmp = cmpxchg((void **)&chain->prev, (void *)prev, (void *)replacement);
> +		tmp = cmpxchg((struct dma_fence __force **)&chain->prev,
> +			      prev, replacement);
>  		if (tmp == prev)
>  			dma_fence_put(tmp);
>  		else
> -- 
> 2.25.1


More information about the Intel-gfx mailing list