[Intel-gfx] [PATCH 3/9] drm/amdgpu: Remove drm_fb_helper_{add, remove}_one_connector calls

[Alex Deucher]

On Mon, Mar 2, 2020 at 8:09 AM Pankaj Bharadiya
<pankaj.laxminarayan.bharadiya at intel.com> wrote:
>
> drm_fb_helper_{add,remove}_one_connector() are dummy functions now
> and serve no purpose. Hence remove their calls.
>
> This is the preparatory step for removing the
> drm_fb_helper_{add,remove}_one_connector() functions from
> drm_fb_helper.h
>
> Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya at intel.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  .../drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 13 -------------
>  1 file changed, 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> index 0ef0eeb16778..0c4faba8ed28 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
> @@ -440,9 +440,6 @@ dm_dp_add_mst_connector(struct drm_dp_mst_topology_mgr *mgr,
>  static void dm_dp_destroy_mst_connector(struct drm_dp_mst_topology_mgr *mgr,
>                                         struct drm_connector *connector)
>  {
> -       struct amdgpu_dm_connector *master = container_of(mgr, struct amdgpu_dm_connector, mst_mgr);
> -       struct drm_device *dev = master->base.dev;
> -       struct amdgpu_device *adev = dev->dev_private;
>         struct amdgpu_dm_connector *aconnector = to_amdgpu_dm_connector(connector);
>
>         DRM_INFO("DM_MST: Disabling connector: %p [id: %d] [master: %p]\n",
> @@ -457,21 +454,11 @@ static void dm_dp_destroy_mst_connector(struct drm_dp_mst_topology_mgr *mgr,
>         }
>
>         drm_connector_unregister(connector);
> -       if (adev->mode_info.rfbdev)
> -               drm_fb_helper_remove_one_connector(&adev->mode_info.rfbdev->helper, connector);
>         drm_connector_put(connector);
>  }
>
>  static void dm_dp_mst_register_connector(struct drm_connector *connector)
>  {
> -       struct drm_device *dev = connector->dev;
> -       struct amdgpu_device *adev = dev->dev_private;
> -
> -       if (adev->mode_info.rfbdev)
> -               drm_fb_helper_add_one_connector(&adev->mode_info.rfbdev->helper, connector);
> -       else
> -               DRM_ERROR("adev->mode_info.rfbdev is NULL\n");
> -
>         drm_connector_register(connector);
>  }
>
> --
> 2.20.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel