[Intel-gfx] [PATCH] drm/i915/selftests: Fix uninitialized variable

Aditya Swarup aditya.swarup at intel.com
Tue Mar 3 14:23:47 UTC 2020


Static code analysis tool identified struct lrc_timestamp data as being
uninitialized and then data.ce[] is being checked for NULL/negative
value in the error path. Initializing data variable fixes the issue.

Cc: Matt Roper <matthew.d.roper at intel.com>
Cc: Chris Wilson <chris at chris-wilson.co.uk>
Signed-off-by: Aditya Swarup <aditya.swarup at intel.com>
---
 drivers/gpu/drm/i915/gt/selftest_lrc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c
index ccf9debacd90..9b75b3c77a5b 100644
--- a/drivers/gpu/drm/i915/gt/selftest_lrc.c
+++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c
@@ -4725,7 +4725,7 @@ static int live_lrc_timestamp(void *arg)
 {
 	struct intel_gt *gt = arg;
 	enum intel_engine_id id;
-	struct lrc_timestamp data;
+	struct lrc_timestamp data = { 0 };
 	const u32 poison[] = {
 		0,
 		S32_MAX,
-- 
2.25.0



More information about the Intel-gfx mailing list