[Intel-gfx] [PATCH 2/2] drm/i915/gt: Propagate change in error status to children on unhold

Mika Kuoppala mika.kuoppala at linux.intel.com
Wed Mar 4 11:54:59 UTC 2020


Chris Wilson <chris at chris-wilson.co.uk> writes:

> As we release the head requests back into the queue, propagate any
> change in error status that may have occurred while the requests were
> temporarily suspended.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/issues/1277
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>

> ---
>  drivers/gpu/drm/i915/gt/intel_lrc.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
> index d123dd7fe98b..5da86a40434c 100644
> --- a/drivers/gpu/drm/i915/gt/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
> @@ -2600,6 +2600,10 @@ static void __execlists_unhold(struct i915_request *rq)
>  			struct i915_request *w =
>  				container_of(p->waiter, typeof(*w), sched);
>  
> +			/* Propagate any change in error status */
> +			if (rq->fence.error)
> +				i915_request_set_error_once(w, rq->fence.error);
> +
>  			if (w->engine != rq->engine)
>  				continue;
>  
> -- 
> 2.25.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx


More information about the Intel-gfx mailing list