[Intel-gfx] [PATCH v2 2/9] drm/i915: Clean up i9xx_load_luts_internal()

[Sharma, Swati2]

On 03-Mar-20 11:03 PM, Ville Syrjala wrote:
> +static void i9xx_load_luts(const struct intel_crtc_state *crtc_state)
> +{
> +	struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
> +	struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
> +	const struct drm_property_blob *gamma_lut = crtc_state->hw.gamma_lut;
> +
> +	assert_pll_enabled(dev_priv, crtc->pipe);
Just a query:
Why won't we have following condition here?
if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DSI))
		assert_dsi_pll_enabled(dev_priv);
or is it applicable only for i965_load_luts() and not for i9xx_load_luts()?

> +
> +	i9xx_load_lut_8(crtc, gamma_lut);
> +}
> +
The patch looks good to me.

Reviewed-by: Swati Sharma <swati2.sharma at intel.com>

-- 
~Swati Sharma