[Intel-gfx] [PATCH] drm/i915/gen12: Disable preemption timeout

Chris Wilson chris at chris-wilson.co.uk
Tue Mar 10 16:06:00 UTC 2020


Quoting Tvrtko Ursulin (2020-03-10 16:00:47)
> @@ -316,7 +317,7 @@ static int intel_engine_setup(struct intel_gt *gt, enum intel_engine_id id)
>         engine->props.max_busywait_duration_ns =
>                 CONFIG_DRM_I915_MAX_REQUEST_BUSYWAIT;
>         engine->props.preempt_timeout_ms =
> -               CONFIG_DRM_I915_PREEMPT_TIMEOUT;
> +               INTEL_GEN(i915) == 12 ? 0 : CONFIG_DRM_I915_PREEMPT_TIMEOUT;

Too hidden.

>         engine->props.stop_timeout_ms =
>                 CONFIG_DRM_I915_STOP_TIMEOUT;
>         engine->props.timeslice_duration_ms =
...

+       /* redacted, leaving OpenCL uninterruptible */
+       if (engine->class == RENDER_CLASS && INTEL_GEN(gt->i915) >= 12)
+               engine->props.preempt_timeout_ms = 0;

Please do include a comment for the misbehaviour.
-Chris


More information about the Intel-gfx mailing list