[Intel-gfx] [PATCH v2] drm/i915/gen12: Disable preemption timeout

Chris Wilson chris at chris-wilson.co.uk
Tue Mar 10 16:30:34 UTC 2020


Quoting Tvrtko Ursulin (2020-03-10 16:24:28)
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> Allow super long OpenCL workloads which cannot be preempted within
> the default timeout to run out of the box.
> 
> v2:
>  * Make it stick out more and apply only to RCS. (Chris)
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> Cc: Michal Mrozek <michal.mrozek at intel.com>

I prefer that we apply these quirks for specific reasons (but that
specific reason may apply to the whole device...),
Acked-by: Chris Wilson <chris at chris-wilson.co.uk>

> ---
>  drivers/gpu/drm/i915/gt/intel_engine_cs.c | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> index 53ac3f00909a..02b1f60c0925 100644
> --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> @@ -275,6 +275,7 @@ static void intel_engine_sanitize_mmio(struct intel_engine_cs *engine)
>  static int intel_engine_setup(struct intel_gt *gt, enum intel_engine_id id)
>  {
>         const struct engine_info *info = &intel_engines[id];
> +       struct drm_i915_private *i915 = gt->i915;

Heh! The goal was to kill i915 from this function.
-Chris


More information about the Intel-gfx mailing list