[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/12] drm/i915/selftests: Add request throughput measurement to perf

[Patchwork]

== Series Details ==

Series: series starting with [01/12] drm/i915/selftests: Add request throughput measurement to perf
URL   : https://patchwork.freedesktop.org/series/74586/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
337d76f47d6b drm/i915/selftests: Add request throughput measurement to perf
-:96: WARNING:LINE_SPACING: Missing a blank line after declarations
#96: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:1519:
+	struct perf_series *ps = arg;
+	IGT_TIMEOUT(end_time);

-:130: WARNING:LINE_SPACING: Missing a blank line after declarations
#130: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:1553:
+	struct i915_request *prev = NULL;
+	IGT_TIMEOUT(end_time);

-:165: WARNING:LINE_SPACING: Missing a blank line after declarations
#165: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:1588:
+	struct perf_series *ps = arg;
+	IGT_TIMEOUT(end_time);

-:188: WARNING:LINE_SPACING: Missing a blank line after declarations
#188: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:1611:
+	struct drm_i915_private *i915 = arg;
+	static int (* const func[])(void *arg) = {

-:196: WARNING:LINE_SPACING: Missing a blank line after declarations
#196: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:1619:
+	struct intel_engine_cs *engine;
+	int (* const *fn)(void *arg);

-:324: WARNING:LINE_SPACING: Missing a blank line after declarations
#324: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:1747:
+	struct intel_context *ce;
+	IGT_TIMEOUT(end_time);

-:392: WARNING:LINE_SPACING: Missing a blank line after declarations
#392: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:1815:
+	struct intel_context *ce;
+	IGT_TIMEOUT(end_time);

-:461: WARNING:LINE_SPACING: Missing a blank line after declarations
#461: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:1884:
+	struct intel_context *ce;
+	IGT_TIMEOUT(end_time);

-:517: WARNING:LINE_SPACING: Missing a blank line after declarations
#517: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:1940:
+	struct drm_i915_private *i915 = arg;
+	static int (* const func[])(void *arg) = {

-:525: WARNING:LINE_SPACING: Missing a blank line after declarations
#525: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:1948:
+	struct intel_engine_cs *engine;
+	int (* const *fn)(void *arg);

-:570: WARNING:YIELD: Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)
#570: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:1993:
+		yield(); /* start all threads before we kthread_stop() */

total: 0 errors, 11 warnings, 0 checks, 610 lines checked
0b0bbf029074 drm/i915: Wrap i915_active in a simple kreffed struct
d9e4ce2af66c drm/i915/perf: Schedule oa_config after modifying the contexts
95d48627060c dma-buf: Prettify typecasts for dma-fence-chain
9685917a8609 dma-buf: Report signaled links inside dma-fence-chain
5a616a23bd5c dma-buf: Exercise dma-fence-chain under selftests
-:33: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#33: 
new file mode 100644

-:61: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#61: FILE: drivers/dma-buf/st-dma-fence-chain.c:24:
+	spinlock_t lock;

-:235: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'find_seqno', this function's name, in a string
#235: FILE: drivers/dma-buf/st-dma-fence-chain.c:198:
+		pr_err("Reported %d for find_seqno(0)!\n", err);

-:244: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'find_seqno', this function's name, in a string
#244: FILE: drivers/dma-buf/st-dma-fence-chain.c:207:
+			pr_err("Reported %d for find_seqno(%d:%d)!\n",

-:249: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'find_seqno', this function's name, in a string
#249: FILE: drivers/dma-buf/st-dma-fence-chain.c:212:
+			pr_err("Incorrect fence reported by find_seqno(%d:%d)\n",

-:272: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'find_seqno', this function's name, in a string
#272: FILE: drivers/dma-buf/st-dma-fence-chain.c:235:
+			pr_err("Error not reported for future fence: find_seqno(%d:%d)!\n",

-:286: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'find_seqno', this function's name, in a string
#286: FILE: drivers/dma-buf/st-dma-fence-chain.c:249:
+			pr_err("Incorrect fence reported by find_seqno(%d:%d)\n",

-:737: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'dma_fence_chain', this function's name, in a string
#737: FILE: drivers/dma-buf/st-dma-fence-chain.c:700:
+	pr_info("sizeof(dma_fence_chain)=%zu\n",

total: 0 errors, 7 warnings, 1 checks, 725 lines checked
1ab5e6f9c4f0 dma-buf: Proxy fence, an unsignaled fence placeholder
-:45: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
new file mode 100644

-:93: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#93: FILE: drivers/dma-buf/dma-fence-proxy.c:18:
+	spinlock_t lock;

-:321: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#321: FILE: drivers/dma-buf/st-dma-fence-proxy.c:20:
+	spinlock_t lock;

-:481: WARNING:MEMORY_BARRIER: memory barrier without comment
#481: FILE: drivers/dma-buf/st-dma-fence-proxy.c:180:
+	smp_store_mb(container_of(cb, struct simple_cb, cb)->seen, true);

total: 0 errors, 2 warnings, 2 checks, 852 lines checked
ec674233ad1c drm/syncobj: Allow use of dma-fence-proxy
4a7e7b3c3161 drm/i915/gem: Teach execbuf how to wait on future syncobj
0e2d624783cd drm/i915/gem: Allow combining submit-fences with syncobj
09f1ab7ebc44 drm/i915/gt: Declare when we enabled timeslicing
e88f97ca9c8b drm/i915/gt: Yield the timeslice if caught waiting on a user semaphore