[Intel-gfx] [PATCH v4 2/3] drm/i915/perf: remove redundant power configuration register override

[Tvrtko Ursulin]

On 06/03/2020 10:05, Lionel Landwerlin wrote:
> The caller of i915_oa_init_reg_state() already sets this.
> 
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> ---
>   drivers/gpu/drm/i915/i915_perf.c | 7 -------
>   1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
> index 0069f09b988c..86c6abaa3e0e 100644
> --- a/drivers/gpu/drm/i915/i915_perf.c
> +++ b/drivers/gpu/drm/i915/i915_perf.c
> @@ -2098,9 +2098,6 @@ gen8_update_reg_state_unlocked(const struct intel_context *ce,
>   	for (i = 0; i < ARRAY_SIZE(flex_regs); i++)
>   		reg_state[ctx_flexeu0 + i * 2 + 1] =
>   			oa_config_flex_reg(stream->oa_config, flex_regs[i]);
> -
> -	reg_state[CTX_R_PWR_CLK_STATE] =
> -		intel_sseu_make_rpcs(ce->engine->i915, &ce->sseu);
>   }
>   
>   struct flex {
> @@ -2906,10 +2903,6 @@ void i915_oa_init_reg_state(const struct intel_context *ce,
>   
>   	/* perf.exclusive_stream serialised by lrc_configure_all_contexts() */
>   	stream = READ_ONCE(engine->i915->perf.exclusive_stream);
> -	/*
> -	 * For gen12, only CTX_R_PWR_CLK_STATE needs update, but the caller
> -	 * is already doing that, so nothing to be done for gen12 here.
> -	 */
>   	if (stream && INTEL_GEN(stream->perf->i915) < 12)
>   		gen8_update_reg_state_unlocked(ce, stream);
>   }
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Regards,

Tvrtko