[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915 Support for integrated privacy screen

Patchwork patchwork at emeril.freedesktop.org
Thu Mar 12 19:12:18 UTC 2020


== Series Details ==

Series: drm/i915 Support for integrated privacy screen
URL   : https://patchwork.freedesktop.org/series/74650/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
a0d97f65392d intel_acpi: Rename drm_dev local variable to dev
500f89acca9c drm/connector: Add support for privacy-screen property
50fff7891e7a drm/i915: Lookup and attach ACPI device node for connectors
d25c3af2f2e2 drm/i915: Add helper code for ACPI privacy screen
-:27: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#27: 
new file mode 100644

-:145: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'conn' - possible side-effects?
#145: FILE: drivers/gpu/drm/i915/display/intel_privacy_screen.c:114:
+#define CONN_NAME(conn)						\
+	(conn->base.kdev ? dev_name(conn->base.kdev) : "NONAME")

-:145: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'conn' may be better as '(conn)' to avoid precedence issues
#145: FILE: drivers/gpu/drm/i915/display/intel_privacy_screen.c:114:
+#define CONN_NAME(conn)						\
+	(conn->base.kdev ? dev_name(conn->base.kdev) : "NONAME")

total: 0 errors, 1 warnings, 2 checks, 220 lines checked
6d59d9dc39bf drm/i915: Enable support for integrated privacy screen



More information about the Intel-gfx mailing list