[Intel-gfx] [RFC 01/10] drm/i915: Expose list of clients in sysfs

Chris Wilson chris at chris-wilson.co.uk
Fri Mar 13 10:36:41 UTC 2020


Quoting Tvrtko Ursulin (2020-03-11 18:26:09)
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index ca5420012a22..7def0930684b 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -1218,12 +1218,14 @@ static void i915_gem_init__mm(struct drm_i915_private *i915)
>         i915_gem_init__objects(i915);
>  }
>  
> -void i915_gem_init_early(struct drm_i915_private *dev_priv)
> +void i915_gem_init_early(struct drm_i915_private *i915)
>  {
> -       i915_gem_init__mm(dev_priv);
> -       i915_gem_init__contexts(dev_priv);
> +       i915_gem_init__mm(i915);
> +       i915_gem_init__contexts(i915);
>  
> -       spin_lock_init(&dev_priv->fb_tracking.lock);
> +       spin_lock_init(&i915->fb_tracking.lock);
> +
> +       i915_drm_clients_init(&i915->clients);

Not from inside GEM, since this is separate bookkeeping. (i915->clients
not i915->gem.clients!)

Other than that grumble,
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list