[Intel-gfx] [PATCH v5 3/3] drm/i915/perf: introduce global sseu pinning

Lionel Landwerlin lionel.g.landwerlin at intel.com
Sat Mar 14 10:33:56 UTC 2020


On 13/03/2020 17:26, Tvrtko Ursulin wrote:
>
> On 13/03/2020 14:34, Lionel Landwerlin wrote:
>> On Gen11 powergating half the execution units is a functional
>> requirement when using the VME samplers. Not fullfilling this
>> requirement can lead to hangs.
>>
>> This unfortunately plays fairly poorly with the NOA requirements. NOA
>> requires a stable power configuration to maintain its configuration.
>>
>> As a result using OA (and NOA feeding into it) so far has required us
>> to use a power configuration that can work for all contexts. The only
>> power configuration fullfilling this is powergating half the execution
>> units.
>>
>> This makes performance analysis for 3D workloads somewhat pointless.
>>
>> Failing to find a solution that would work for everybody, this change
>> introduces a new i915-perf stream open parameter that punts the
>> decision off to userspace. If this parameter is omitted, the existing
>> Gen11 behavior remains (half EU array powergating).
>>
>> This change takes the initiative to move all perf related sseu
>> configuration into i915_perf.c
>>
>> v2: Make parameter priviliged if different from default
>>
>> v3: Fix context modifying its sseu config while i915-perf is enabled
>>
>> v4: Always consider global sseu a privileged operation (Tvrtko)
>>      Override req_sseu point in intel_sseu_make_rpcs() (Tvrtko)
>>      Remove unrelated changes (Tvrtko)
>>
>> v5: Some typos (Tvrtko)
>>      Process sseu param in read_properties_unlocked() (Tvrtko)
>
> git add ? :)
>
> Regards,
>
> Tvrtko


Oh dear...

Sorry for that.


-Lionel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20200314/01ba1eaa/attachment.htm>


More information about the Intel-gfx mailing list