[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Trigger Modeset at boot for audio codec init (rev2)

Patchwork patchwork at emeril.freedesktop.org
Mon Mar 23 16:57:27 UTC 2020


== Series Details ==

Series: drm/i915/display: Trigger Modeset at boot for audio codec init (rev2)
URL   : https://patchwork.freedesktop.org/series/74828/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
0db59c6d9bd5 drm/i915/display: Trigger Modeset at boot for audio codec init
-:33: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#33: 
To: Ville Syrjälä <ville.syrjala at linux.intel.com>; Shankar, Uma <uma.shankar at intel.com>

-:87: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 33e059a2e4df ("drm/i915/psr: Force PSR probe only after full initialization")'
#87: 
> > commit 33e059a2e4df454359f642f2235af39de9d3e914

-:105: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'intel_atomic_check', this function's name, in a string
#105: FILE: drivers/gpu/drm/i915/display/intel_display.c:14746:
+	DRM_INFO("SA: intel_atomic_check: uapi change \n");

-:105: WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#105: FILE: drivers/gpu/drm/i915/display/intel_display.c:14746:
+	DRM_INFO("SA: intel_atomic_check: uapi change \n");

-:112: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#112: FILE: drivers/gpu/drm/i915/display/intel_display.c:14751:
 					    new_crtc_state, i) {
+

-:113: WARNING:LONG_LINE: line over 100 characters
#113: FILE: drivers/gpu/drm/i915/display/intel_display.c:14752:
+		DRM_INFO("SA2: intel_atomic_check: new_crtc_state->uapi.mode.private_flags= %d, old_crtc_state->uapi.mode.private_flags= %d  \n", new_crtc_state->uapi.mode.private_flags, old_crtc_state->uapi.mode.private_flags );

-:113: ERROR:SPACING: space prohibited before that close parenthesis ')'
#113: FILE: drivers/gpu/drm/i915/display/intel_display.c:14752:
+		DRM_INFO("SA2: intel_atomic_check: new_crtc_state->uapi.mode.private_flags= %d, old_crtc_state->uapi.mode.private_flags= %d  \n", new_crtc_state->uapi.mode.private_flags, old_crtc_state->uapi.mode.private_flags );

-:113: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'intel_atomic_check', this function's name, in a string
#113: FILE: drivers/gpu/drm/i915/display/intel_display.c:14752:
+		DRM_INFO("SA2: intel_atomic_check: new_crtc_state->uapi.mode.private_flags= %d, old_crtc_state->uapi.mode.private_flags= %d  \n", new_crtc_state->uapi.mode.private_flags, old_crtc_state->uapi.mode.private_flags );

-:113: WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#113: FILE: drivers/gpu/drm/i915/display/intel_display.c:14752:
+		DRM_INFO("SA2: intel_atomic_check: new_crtc_state->uapi.mode.private_flags= %d, old_crtc_state->uapi.mode.private_flags= %d  \n", new_crtc_state->uapi.mode.private_flags, old_crtc_state->uapi.mode.private_flags );

-:118: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 3 errors, 6 warnings, 1 checks, 17 lines checked



More information about the Intel-gfx mailing list