[Intel-gfx] [PATCH] drm/i915/gem: Ignore readonly failures when updating relocs

Andi Shyti andi at etezian.org
Tue Mar 31 21:37:14 UTC 2020


Hi Chris,

> If the user passes in a readonly reloc[], by the time we notice we have
> already commited to modifying the execobjects, or have indeed done so
> already. Reporting the failure just compounds the issue as we have no
> second pass to fall back to anymore.

It's also written in the comment, btw.

> Testcase: igt/gem_exec_reloc/readonly

if one day we will change igt, we can't fix this commit.

> Fixes: 7dc8f1143778 ("drm/i915/gem: Drop relocation slowpath")
> References: fddcd00a49e9 ("drm/i915: Force the slow path after a user-write error")
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Matthew Auld <matthew.auld at intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Reviewed-by: Andi Shyti <andi.shyti at intel.com>

Andi


More information about the Intel-gfx mailing list