[Intel-gfx] [PATCH v11 2/4] drm/i915/perf: stop using the kernel context

[Lionel Landwerlin]

On 04/05/2020 13:42, Chris Wilson wrote:
> Quoting Lionel Landwerlin (2020-05-04 11:31:44)
>> diff --git a/drivers/gpu/drm/i915/i915_perf_types.h b/drivers/gpu/drm/i915/i915_perf_types.h
>> index a36a455ae336..a8b903592a39 100644
>> --- a/drivers/gpu/drm/i915/i915_perf_types.h
>> +++ b/drivers/gpu/drm/i915/i915_perf_types.h
>> @@ -16,6 +16,7 @@
>>   #include <linux/uuid.h>
>>   #include <linux/wait.h>
>>   
>> +#include "gt/intel_context_types.h"
>>   #include "gt/intel_sseu.h"
>>   #include "i915_reg.h"
>>   #include "intel_wakeref.h"
>> @@ -311,6 +312,12 @@ struct i915_perf_stream {
>>           * buffer should be checked for available data.
>>           */
>>          u64 poll_oa_period;
>> +
>> +       /**
>> +        * @config_context: A logical context for use by the perf stream for
>> +        * configuring the HW.
>> +        */
>> +       struct intel_context *config_context;
> Looks like you just want a forward decl of struct intel_context rather
> than the whole header.


Fair, plus it's already forward declared.


-Lionel


>
>>   };
>>   
>>   /**
>> @@ -348,7 +355,8 @@ struct i915_oa_ops {
>>           * @disable_metric_set: Remove system constraints associated with using
>>           * the OA unit.
>>           */
>> -       void (*disable_metric_set)(struct i915_perf_stream *stream);
>> +       void (*disable_metric_set)(struct i915_perf_stream *stream,
>> +                                  struct i915_active *active);
>>   
>>          /**
>>           * @oa_enable: Enable periodic sampling
>> -- 
>> 2.26.2
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>>