[Intel-gfx] [PATCH] drm/i915/gen12: Add aux table invalidate for all engines

Chris Wilson chris at chris-wilson.co.uk
Thu May 7 16:22:20 UTC 2020


Quoting Mika Kuoppala (2020-05-07 15:20:45)
> All engines, exception being blitter as it does not
> care about the form, can access compressed surfaces.
> 
> So we need to add forced aux table invalidates
> for those engines.
> 
> v2: virtual instance masking (Chris)
> v3: bug on if not found (Chris)
> 
> References: d248b371f747 ("drm/i915/gen12: Invalidate aux table entries forcibly")
> References bspec#43904, hsdes#1809175790
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Chuansheng Liu <chuansheng.liu at intel.com>
> Cc: Rafael Antognolli <rafael.antognolli at intel.com>
> Signed-off-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>

The code handles the more complicated vengs without exploding, so looks
good. But I still think is a w/a and only deserves an ack as something
that empirically works [although we have a lack of evidence situation
here :],
Acked-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the Intel-gfx mailing list