[Intel-gfx] [PATCH 16/24] drm/i915/selftests: Always call the provided engine->emit_init_breadcrumb

Mika Kuoppala mika.kuoppala at linux.intel.com
Thu May 14 07:55:38 UTC 2020


Chris Wilson <chris at chris-wilson.co.uk> writes:

> While this does not appear to fix any issues, the backend itself knows
> when it wants to emit a breadcrumb, so let it make the final call.
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>

> ---
>  drivers/gpu/drm/i915/selftests/i915_perf.c   | 3 +--
>  drivers/gpu/drm/i915/selftests/igt_spinner.c | 3 +--
>  2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_perf.c b/drivers/gpu/drm/i915/selftests/i915_perf.c
> index 5608fab98d5d..ca0c9dbab713 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_perf.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_perf.c
> @@ -221,8 +221,7 @@ static int live_noa_delay(void *arg)
>  		goto out;
>  	}
>  
> -	if (rq->engine->emit_init_breadcrumb &&
> -	    i915_request_timeline(rq)->has_initial_breadcrumb) {
> +	if (rq->engine->emit_init_breadcrumb) {
>  		err = rq->engine->emit_init_breadcrumb(rq);
>  		if (err) {
>  			i915_request_add(rq);
> diff --git a/drivers/gpu/drm/i915/selftests/igt_spinner.c b/drivers/gpu/drm/i915/selftests/igt_spinner.c
> index 9ad4ab088466..e35ba5f9e73f 100644
> --- a/drivers/gpu/drm/i915/selftests/igt_spinner.c
> +++ b/drivers/gpu/drm/i915/selftests/igt_spinner.c
> @@ -169,8 +169,7 @@ igt_spinner_create_request(struct igt_spinner *spin,
>  
>  	intel_gt_chipset_flush(engine->gt);
>  
> -	if (engine->emit_init_breadcrumb &&
> -	    i915_request_timeline(rq)->has_initial_breadcrumb) {
> +	if (engine->emit_init_breadcrumb) {
>  		err = engine->emit_init_breadcrumb(rq);
>  		if (err)
>  			goto cancel_rq;
> -- 
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx


More information about the Intel-gfx mailing list