[Intel-gfx] [PATCH] drm/i915/display: Return error from dbuf allocation failure

[Ville Syrjälä]

On Sat, May 16, 2020 at 08:09:40PM +0100, Chris Wilson wrote:
> drivers/gpu/drm/i915/intel_pm.c:5920 skl_ddb_add_affected_pipes() error: uninitialized symbol 'ret'.
> 
> Fixes: 3cf43cdc63fb ("drm/i915: Introduce proper dbuf state")
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Stanislav Lisovskiy <stanislav.lisovskiy at intel.com>
> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>  drivers/gpu/drm/i915/intel_pm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index a21e36ed1a77..762a5184fc69 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -5917,7 +5917,7 @@ skl_ddb_add_affected_pipes(struct intel_atomic_state *state)
>  
>  		new_dbuf_state = intel_atomic_get_dbuf_state(state);
>  		if (IS_ERR(new_dbuf_state))
> -			return ret;
> +			return PTR_ERR(new_dbuf_state);

Doh.

Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

>  
>  		old_dbuf_state = intel_atomic_get_old_dbuf_state(state);
>  
> -- 
> 2.20.1

-- 
Ville Syrjälä
Intel