[Intel-gfx] [PATCH] drm/i915/selftests: Flush the submission, not cancel it!

[Tvrtko Ursulin]

On 21/05/2020 13:43, Chris Wilson wrote:
> Use intel_engine_flush_submission() when we want to ensure that the
> tasklet is run. tasklet_kill(), while it may ensure that an ongoing
> tasklet is completed, also prevents the tasklet from running if it's
> already scheduled and hasn't yet been run.
> 
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1874
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>   drivers/gpu/drm/i915/gt/selftest_lrc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c
> index ef38dd52945c..66f710b1b61e 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c
> @@ -332,7 +332,7 @@ static int live_unlite_restore(struct intel_gt *gt, int prio)
>   		i915_request_put(rq[0]);
>   
>   err_ce:
> -		tasklet_kill(&engine->execlists.tasklet); /* flush submission */
> +		intel_engine_flush_submission(engine);
>   		igt_spinner_end(&spin);
>   		for (n = 0; n < ARRAY_SIZE(ce); n++) {
>   			if (IS_ERR_OR_NULL(ce[n]))
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Regards,

Tvrtko