[Intel-gfx] [PATCH v1] drm/i915: Fix includes and local vars order

[Lisovskiy, Stanislav]

On Fri, May 22, 2020 at 02:05:26PM +0100, Chris Wilson wrote:
> Quoting Stanislav Lisovskiy (2020-05-22 13:55:34)
> > Removed duplicate include and fixed comment > 80 chars.
> > 
> > Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy at intel.com>
> > ---
> >  drivers/gpu/drm/i915/display/intel_bw.c    | 43 ++++++++++++----------
> >  drivers/gpu/drm/i915/display/intel_bw.h    |  2 +-
> >  drivers/gpu/drm/i915/display/intel_cdclk.c |  2 +-
> >  drivers/gpu/drm/i915/display/intel_cdclk.h |  1 +
> >  drivers/gpu/drm/i915/intel_pm.c            |  3 +-
> >  drivers/gpu/drm/i915/intel_pm.h            |  2 +-
> >  6 files changed, 29 insertions(+), 24 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
> > index 8d2f58e39595..db9ba8f922bd 100644
> > --- a/drivers/gpu/drm/i915/display/intel_bw.c
> > +++ b/drivers/gpu/drm/i915/display/intel_bw.c
> > @@ -5,13 +5,12 @@
> >  
> >  #include <drm/drm_atomic_state_helper.h>
> >  
> > +#include "intel_atomic.h"
> >  #include "intel_bw.h"
> > -#include "intel_pm.h"
> > +#include "intel_cdclk.h"
> >  #include "intel_display_types.h"
> > -#include "intel_sideband.h"
> > -#include "intel_atomic.h"
> >  #include "intel_pm.h"
> > -#include "intel_cdclk.h"
> > +#include "intel_sideband.h"
> 
> There was also the accidental remove of a '\n' before
> intel_bw_crtc_update()

Weird..how didn't I spot this.

> 
> > diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c
> > index dda9bae02a86..643701cca6ba 100644
> > --- a/drivers/gpu/drm/i915/display/intel_cdclk.c
> > +++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
> > @@ -23,10 +23,10 @@
> >  
> >  #include <linux/time.h>
> 
> \n between system and local includes
> 
> >  #include "intel_atomic.h"
> > +#include "intel_bw.h"
> >  #include "intel_cdclk.h"
> >  #include "intel_display_types.h"
> >  #include "intel_sideband.h"
> > -#include "intel_bw.h"
> 
> 2 more nits then
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
> s/Reviewed/Critiqued/
> -Chris