[Intel-gfx] [PATCH] drm/i915: Revert CDCLK changes to unbreak geminilake

Lisovskiy, Stanislav stanislav.lisovskiy at intel.com
Mon May 25 08:15:31 UTC 2020


On Mon, May 25, 2020 at 09:16:54AM +0100, Chris Wilson wrote:
> Quoting Lisovskiy, Stanislav (2020-05-25 09:07:54)
> > On Mon, May 25, 2020 at 09:07:31AM +0100, Chris Wilson wrote:
> > > This reverts
> > > cac91e671ad5 ("drm/i915: Fix includes and local vars order")
> > > 82ea174dc542 ("drm/i915: Remove unneeded hack now for CDCLK")
> > > cd1915460861 ("drm/i915: Adjust CDCLK accordingly to our DBuf bw needs")
> > > 
> > > Cc: Stanislav Lisovskiy <stanislav.lisovskiy at intel.com>
> > > Cc: Manasi Navare <manasi.d.navare at intel.com>
> > > Cc: "Ville Syrjälä" <ville.syrjala at linux.intel.com>
> > 
> > 
> > I guess we still need to check more precisely if this patch caused
> > this - or have you already bisected that?
> 
> This was found by unwinding the patches on CI.
> 
> > It is rather strange that it breaks only a GLK and only single test.
> 
> Bug detection is purely serendipitous.
> -Chris

Ok then lets rewind those - then it will become clear at least.

Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy at intel.com>


More information about the Intel-gfx mailing list