[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Asynchronous flip implementation for i915 (rev3)

Patchwork patchwork at emeril.freedesktop.org
Thu May 28 06:35:03 UTC 2020


== Series Details ==

Series: Asynchronous flip implementation for i915 (rev3)
URL   : https://patchwork.freedesktop.org/series/74386/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
239c9f562cbf drm/i915: Add enable/disable flip done and flip done handler
-:28: WARNING:TYPO_SPELLING: 'begining' may be misspelled - perhaps 'beginning'?
#28: 
    -Make the pending vblank event NULL in the begining of

total: 0 errors, 1 warnings, 0 checks, 123 lines checked
54febd5358c0 drm/i915: Add support for async flips in I915
85045ff08f4f drm/i915: Add checks specific to async flips
-:59: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'old_plane_state->color_plane[0].x !=
 		     new_plane_state->color_plane[0].x'
#59: FILE: drivers/gpu/drm/i915/display/intel_display.c:14830:
+		if ((old_plane_state->color_plane[0].x !=
+		     new_plane_state->color_plane[0].x) ||
+		    (old_plane_state->color_plane[0].y !=
+		     new_plane_state->color_plane[0].y)) {

-:59: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'old_plane_state->color_plane[0].y !=
 		     new_plane_state->color_plane[0].y'
#59: FILE: drivers/gpu/drm/i915/display/intel_display.c:14830:
+		if ((old_plane_state->color_plane[0].x !=
+		     new_plane_state->color_plane[0].x) ||
+		    (old_plane_state->color_plane[0].y !=
+		     new_plane_state->color_plane[0].y)) {

total: 0 errors, 0 warnings, 2 checks, 67 lines checked
35ffa8ae0d13 drm/i915: Do not call drm_crtc_arm_vblank_event in async flips
f13f002114a6 drm/i915: Enable async flips in i915



More information about the Intel-gfx mailing list