[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/11] drm/i915/gt: Prevent timeslicing into unpreemptable requests

Patchwork patchwork at emeril.freedesktop.org
Thu May 28 07:54:46 UTC 2020


== Series Details ==

Series: series starting with [01/11] drm/i915/gt: Prevent timeslicing into unpreemptable requests
URL   : https://patchwork.freedesktop.org/series/77729/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
55a37e373e5e drm/i915/gt: Prevent timeslicing into unpreemptable requests
afdac8049573 drm/i915/gt: Don't declare hangs if engine is stalled
1fbd041e4db7 drm/i915/gem: Async GPU relocations only
f0df73f7c503 drm/i915: Add list_for_each_entry_safe_continue_reverse
-:20: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pos' - possible side-effects?
#20: FILE: drivers/gpu/drm/i915/i915_utils.h:269:
+#define list_for_each_entry_safe_continue_reverse(pos, n, head, member)	\
+	for (pos = list_prev_entry(pos, member),			\
+	     n = list_prev_entry(pos, member);				\
+	     &pos->member != (head);					\
+	     pos = n, n = list_prev_entry(n, member))

-:20: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'n' - possible side-effects?
#20: FILE: drivers/gpu/drm/i915/i915_utils.h:269:
+#define list_for_each_entry_safe_continue_reverse(pos, n, head, member)	\
+	for (pos = list_prev_entry(pos, member),			\
+	     n = list_prev_entry(pos, member);				\
+	     &pos->member != (head);					\
+	     pos = n, n = list_prev_entry(n, member))

-:20: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'member' - possible side-effects?
#20: FILE: drivers/gpu/drm/i915/i915_utils.h:269:
+#define list_for_each_entry_safe_continue_reverse(pos, n, head, member)	\
+	for (pos = list_prev_entry(pos, member),			\
+	     n = list_prev_entry(pos, member);				\
+	     &pos->member != (head);					\
+	     pos = n, n = list_prev_entry(n, member))

total: 0 errors, 0 warnings, 3 checks, 12 lines checked
9c0586c970ee drm/i915/gem: Separate reloc validation into an earlier step
-:101: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#101: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1408:
+				return (int)offset;
+			} else {

total: 0 errors, 1 warnings, 0 checks, 215 lines checked
75206988e02e drm/i915/gem: Lift GPU relocation allocation
cf93e1fda67c drm/i915/gem: Add all GPU reloc awaits/signals en masse
167c2cf62a5f drm/i915/gem: Build the reloc request first
53c8e6601d79 dma-buf: Proxy fence, an unsignaled fence placeholder
-:45: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
new file mode 100644

-:427: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#427: FILE: drivers/dma-buf/st-dma-fence-proxy.c:20:
+	spinlock_t lock;

total: 0 errors, 1 warnings, 1 checks, 1147 lines checked
eb43b54bec13 drm/i915: Unpeel awaits on a proxy fence
6571dd270ea5 drm/i915/gem: Make relocations atomic within execbuf



More information about the Intel-gfx mailing list