[Intel-gfx] [CI 3/3] drm/i915/gt: Move pm debug files into a gt aware debugfs

Chris Wilson chris at chris-wilson.co.uk
Wed Nov 4 10:11:53 UTC 2020


Quoting Joonas Lahtinen (2020-11-04 10:05:32)
> Quoting Chris Wilson (2019-12-22 16:40:46)
> > From: Andi Shyti <andi.shyti at intel.com>
> > 
> > The GT system is becoming more and more a stand-alone system in
> > i915 and it's fair to assign it its own debugfs directory.
> > 
> > rc6, rps and llc debugfs files are gt related, move them into the
> > gt debugfs directory.
> > 
> > Signed-off-by: Andi Shyti <andi.shyti at intel.com>
> > Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > ---
> >  drivers/gpu/drm/i915/Makefile             |   3 +
> >  drivers/gpu/drm/i915/gt/debugfs_engines.c |  36 ++
> >  drivers/gpu/drm/i915/gt/debugfs_engines.h |  15 +
> >  drivers/gpu/drm/i915/gt/debugfs_gt.c      |  42 ++
> >  drivers/gpu/drm/i915/gt/debugfs_gt.h      |  39 ++
> >  drivers/gpu/drm/i915/gt/debugfs_gt_pm.c   | 601 ++++++++++++++++++++++
> >  drivers/gpu/drm/i915/gt/debugfs_gt_pm.h   |  14 +
> >  drivers/gpu/drm/i915/gt/intel_gt.c        |   3 +
> >  8 files changed, 753 insertions(+)
> >  create mode 100644 drivers/gpu/drm/i915/gt/debugfs_engines.c
> >  create mode 100644 drivers/gpu/drm/i915/gt/debugfs_engines.h
> >  create mode 100644 drivers/gpu/drm/i915/gt/debugfs_gt.c
> >  create mode 100644 drivers/gpu/drm/i915/gt/debugfs_gt.h
> >  create mode 100644 drivers/gpu/drm/i915/gt/debugfs_gt_pm.c
> >  create mode 100644 drivers/gpu/drm/i915/gt/debugfs_gt_pm.h
> 
> This patch seems to actually copy the code, forgetting to remove the old
> code. Let's have a follow-up patch that eliminates the duplication.

We couldn't remove the old code without making changes to igt to work
out what the appropriate GT directory would be for the test. That is
still unknowable from userspace... So as a matter of convenience we kept
the old entry point so that we could dump everything under the device.

More work could be done to remove the duplication of debug code, but
equally we could use more specialised debug info for the igts.
-Chris


More information about the Intel-gfx mailing list