[Intel-gfx] [PATCH 4/6] drm/i915/gt: Refactor _wa_add to reuse wa_index and wa_list_grow

Chris Wilson chris.p.wilson at intel.com
Fri Nov 13 11:02:52 UTC 2020


Quoting Tvrtko Ursulin (2020-11-13 10:40:07)
> 
> On 12/11/2020 19:44, Chris Wilson wrote:
> > Quoting Umesh Nerlige Ramappa (2020-10-10 01:21:03)
> > An inherited problem, but I'm a little unnerved by the apparent leak of
> > wa->list here.
> > 
> > Paging Tvrtko to see if he can remember if there's a hidden trick.
> 
> I don't see any tricks, just a memory leak for all lists with more than 
> 16 unique registers on the wa list. :(

As I read it, since each pair of perf open/close will cause us to
reallocate the lists, we need to address this leak first before it
becomes user controllable. Apologies for yet another delay.
-Chris
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.


More information about the Intel-gfx mailing list