[Intel-gfx] [PATCH i-g-t] gem_wsim: Implement device selection

Chris Wilson chris at chris-wilson.co.uk
Tue Nov 17 12:37:28 UTC 2020


Quoting Tvrtko Ursulin (2020-11-17 12:33:11)
> 
> On 17/11/2020 12:18, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2020-11-17 11:40:50)
> >> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> >>
> >> -L and -D <device> on the command line.
> >>
> >> With no device specified tool tries to find i915 discrete or integrated in
> >> that order.
> > 
> > Ok, looks straightforward enough. (I still like having an idiot's guide
> > with examples of -L output and what to pass to -D).
> > 
> >> +       fd = igt_open_card(&card);
> >> +       igt_require(fd);
> > 
> > Does igt_require() still generate weirdness when used outside of igt
> > tests?
> 
> It appears to do nothing. But more importantly I don't know how I ended 
> up with it here. Probably some copy & paste again.
> 
> > Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
> 
> Can I convert to igt_assert and keep the r-b?

Make it return sensibly with a wsim_err.
-Chris


More information about the Intel-gfx mailing list