[Intel-gfx] [PATCH] drm/i915/phy: Quieten state loss across suspend

Chris Wilson chris at chris-wilson.co.uk
Tue Nov 17 17:14:11 UTC 2020


When the HW is powered down, the register state and links are lost. This
may be an issue in the firmware, or in the code expectations; whatever
it is, it is expected behaviour now for Tigerlake; stop warning!

References: https://gitlab.freedesktop.org/drm/intel/-/issues/2411
Fixes: 239bef676d8e ("drm/i915/display: Implement new combo phy initialization step")
Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
Cc: Clinton A Taylor <clinton.a.taylor at intel.com>
Cc: Lucas De Marchi <lucas.demarchi at intel.com>
Cc: Matt Roper <matthew.d.roper at intel.com>
Cc: José Roberto de Souza <jose.souza at intel.com>
Cc: <stable at vger.kernel.org> # v5.9+
---
 drivers/gpu/drm/i915/display/intel_combo_phy.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_combo_phy.c b/drivers/gpu/drm/i915/display/intel_combo_phy.c
index d5ad61e4083e..9a87df982af8 100644
--- a/drivers/gpu/drm/i915/display/intel_combo_phy.c
+++ b/drivers/gpu/drm/i915/display/intel_combo_phy.c
@@ -428,9 +428,9 @@ static void icl_combo_phys_uninit(struct drm_i915_private *dev_priv)
 
 		if (phy == PHY_A &&
 		    !icl_combo_phy_verify_state(dev_priv, phy))
-			drm_warn(&dev_priv->drm,
-				 "Combo PHY %c HW state changed unexpectedly\n",
-				 phy_name(phy));
+			drm_dbg_kms(&dev_priv->drm,
+				    "Combo PHY %c HW state changed unexpectedly\n",
+				    phy_name(phy));
 
 		if (!has_phy_misc(dev_priv, phy))
 			goto skip_phy_misc;
-- 
2.20.1



More information about the Intel-gfx mailing list