[Intel-gfx] [PATCH] drm/i915/gt: Remember to free the virtual breadcrumbs

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Wed Nov 18 14:10:14 UTC 2020


On 18/11/2020 13:38, Chris Wilson wrote:
> Since we allocate some breadcrumbs for the virtual engine, and the
> virtual engine has a custom destructor, we also need to free the
> breadcrumbs after use.
> 
> Fixes: b3786b29379c ("drm/i915/gt: Distinguish the virtual breadcrumbs from the irq breadcrumbs")
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> ---
>   drivers/gpu/drm/i915/gt/intel_lrc.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
> index 8a51c1c3a091..eaa0a9f38ae5 100644
> --- a/drivers/gpu/drm/i915/gt/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
> @@ -5512,6 +5512,7 @@ static void virtual_context_destroy(struct kref *kref)
>   		__execlists_context_fini(&ve->context);
>   	intel_context_fini(&ve->context);
>   
> +	intel_breadcrumbs_free(ve->base.breadcrumbs);
>   	intel_engine_free_request_pool(&ve->base);
>   
>   	kfree(ve->bonds);
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Regards,

Tvrtko


More information about the Intel-gfx mailing list