[Intel-gfx] [PATCH i-g-t] Cast negative debugfs values to u64

Chris Wilson chris at chris-wilson.co.uk
Tue Nov 24 13:41:39 UTC 2020


Quoting Tvrtko Ursulin (2020-11-24 13:28:15)
> 
> On 24/11/2020 12:34, Chris Wilson wrote:
> > -             igt_sysfs_set(dir, "i915_wedged", "-1");
> > +             igt_sysfs_printf(dir, "i915_wedged", "%llu", -1ull);
> 
> Set to printf conversion is okay. Maybe we could later add 
> igt_sysfs_setu32 for simplicity but maybe it would also be too much api.

Yup, I thought printf would be generic enough to cover all users, and
was not convinced that wrapping the common integers added enough
convenience as printf is a ubiquitous API.
-Chris


More information about the Intel-gfx mailing list