[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Remove obj->mm.lock! (rev11)

Wed Nov 25 12:30:16 UTC 2020

== Series Details ==

Series: drm/i915: Remove obj->mm.lock! (rev11)
URL   : https://patchwork.freedesktop.org/series/82337/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
354c163af2a9 drm/i915: Do not share hwsp across contexts any more, v6
-:555: WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#555: FILE: drivers/gpu/drm/i915/gt/intel_timeline.c:268:
+	if (TIMELINE_SEQNO_BYTES <= BIT(5) && (next_ofs & BIT(5)))

total: 0 errors, 1 warnings, 0 checks, 922 lines checked
01064b64bfb8 drm/i915: Pin timeline map after first timeline pin, v3.
-:13: WARNING:TYPO_SPELLING: 'arithmatic' may be misspelled - perhaps 'arithmetic'?
#13: 
- Fix NULL + XX arithmatic, use casts. (kbuild)

total: 0 errors, 1 warnings, 0 checks, 296 lines checked
795a815293db drm/i915: Move cmd parser pinning to execbuffer
48bd705f7374 drm/i915: Add missing -EDEADLK handling to execbuf pinning, v2.
-:59: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#59: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:451:
+		err = i915_vma_pin_ww(vma, &eb->ww,
 					     entry->pad_to_size,

total: 0 errors, 0 warnings, 1 checks, 75 lines checked
4a2193e44ceb drm/i915: Ensure we hold the object mutex in pin correctly.
8608559e365a drm/i915: Add gem object locking to madvise.
8d38426503e9 drm/i915: Move HAS_STRUCT_PAGE to obj->flags
-:110: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#110: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.c:63:
+			  struct lock_class_key *key, unsigned flags)

-:133: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#133: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:27:
+			  unsigned alloc_flags);

total: 0 errors, 2 warnings, 0 checks, 348 lines checked
dca364346602 drm/i915: Rework struct phys attachment handling
a1fdfca8521d drm/i915: Convert i915_gem_object_attach_phys() to ww locking, v2.
d4601a07e16d drm/i915: make lockdep slightly happier about execbuf.
93b3d5931a52 drm/i915: Disable userptr pread/pwrite support.
0c07739fa834 drm/i915: No longer allow exporting userptr through dma-buf
90ae76a78883 drm/i915: Reject more ioctls for userptr
7171ba7856f7 drm/i915: Reject UNSYNCHRONIZED for userptr, v2.
4407f9c68161 drm/i915: Make compilation of userptr code depend on MMU_NOTIFIER.
abf248ad32f8 drm/i915: Fix userptr so we do not have to worry about obj->mm.lock, v5.
-:291: WARNING:LONG_LINE: line length of 121 exceeds 100 columns
#291: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:561:
+static inline int i915_gem_object_userptr_submit_init(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); return -ENODEV; }

-:292: WARNING:LONG_LINE: line length of 121 exceeds 100 columns
#292: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:562:
+static inline int i915_gem_object_userptr_submit_done(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); return -ENODEV; }

-:293: WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#293: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:563:
+static inline void i915_gem_object_userptr_submit_fini(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); }

-:351: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#351: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:2:
  * SPDX-License-Identifier: MIT

-:355: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#355: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:6:
+ *
+  * Based on amdgpu_mn, which bears the following notice:

-:356: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#356: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:7:
+  * Based on amdgpu_mn, which bears the following notice:
+ *

-:469: WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#469: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:63:
+	struct drm_i915_gem_object *obj = container_of(mni, struct drm_i915_gem_object, userptr.notifier);

-:1123: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#1123: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:293:
+	pinned = ret = 0;

-:1138: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1138: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:308:
+	if (mmu_interval_read_retry(&obj->userptr.notifier,
+		!obj->userptr.page_ref ? notifier_seq :

-:1259: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#1259: FILE: drivers/gpu/drm/i915/i915_drv.h:598:
+	spinlock_t notifier_lock;

total: 0 errors, 7 warnings, 3 checks, 1202 lines checked
280fdc0223eb drm/i915: Flatten obj->mm.lock
8a0dd4b2d00c drm/i915: Populate logical context during first pin.
-:180: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#180: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:5581:
+virtual_context_pre_pin(struct intel_context *ce,
+			  struct i915_gem_ww_ctx *ww, void **vaddr)

total: 0 errors, 0 warnings, 1 checks, 169 lines checked
8ca3e4c22563 drm/i915: Make ring submission compatible with obj->mm.lock removal, v2.
ff391fe16ffa drm/i915: Handle ww locking in init_status_page
a940cfe48b68 drm/i915: Rework clflush to work correctly without obj->mm.lock.
4c7d3f7b4afd drm/i915: Pass ww ctx to intel_pin_to_display_plane
4baca447c52e drm/i915: Add object locking to vm_fault_cpu
080e1d0e580c drm/i915: Move pinning to inside engine_wa_list_verify()
-:57: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#57: FILE: drivers/gpu/drm/i915/gt/intel_workarounds.c:2209:
+	err = i915_vma_pin_ww(vma, &ww, 0, 0,
+			   i915_vma_is_ggtt(vma) ? PIN_GLOBAL : PIN_USER);

total: 0 errors, 0 warnings, 1 checks, 109 lines checked
25344ad4738a drm/i915: Take reservation lock around i915_vma_pin.
e3cfef3065b1 drm/i915: Make intel_init_workaround_bb more compatible with ww locking.
6d462b44b678 drm/i915: Make __engine_unpark() compatible with ww locking.
-:10: WARNING:REPEATED_WORD: Possible repeated word: 'many'
#10: 
many many places where rpm is used, I chose the safest option

total: 0 errors, 1 warnings, 0 checks, 16 lines checked
5dcc2390199a drm/i915: Take obj lock around set_domain ioctl
c3f2b4de7672 drm/i915: Defer pin calls in buffer pool until first use by caller.
605474284ddd drm/i915: Fix pread/pwrite to work with new locking rules.
-:32: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#32: 
deleted file mode 100644

total: 0 errors, 1 warnings, 0 checks, 359 lines checked
5fc24d00bb93 drm/i915: Fix workarounds selftest, part 1
f7f7e8bc6776 drm/i915: Prepare for obj->mm.lock removal
-:132: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: "Thomas Hellström" <thomas.hellstrom at intel.com>' != 'Signed-off-by: Thomas Hellström <thomas.hellstrom at linux.intel.com>'

total: 0 errors, 1 warnings, 0 checks, 96 lines checked
65ac0323ea16 drm/i915: Add igt_spinner_pin() to allow for ww locking around spinner.
7f8987032ba6 drm/i915: Add ww locking around vm_access()
717105a7c59a drm/i915: Increase ww locking for perf.
083b628fd9fc drm/i915: Lock ww in ucode objects correctly
168fbc3307bd drm/i915: Add ww locking to dma-buf ops.
9482157256a8 drm/i915: Add missing ww lock in intel_dsb_prepare.
79a5cbe83215 drm/i915: Fix ww locking in shmem_create_from_object
7144706bf9b7 drm/i915: Use a single page table lock for each gtt.
-:112: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#112: FILE: drivers/gpu/drm/i915/gt/intel_gtt.c:85:
+		return i915_gem_object_lock(vm->scratch[0], ww);
+	} else {

total: 0 errors, 1 warnings, 0 checks, 154 lines checked
ddc5495652aa drm/i915/selftests: Prepare huge_pages testcases for obj->mm.lock removal.
643e7c8989cf drm/i915/selftests: Prepare client blit for obj->mm.lock removal.
404d44fb5c23 drm/i915/selftests: Prepare coherency tests for obj->mm.lock removal.
ed7c36ba915d drm/i915/selftests: Prepare context tests for obj->mm.lock removal.
b4ee5afba5f7 drm/i915/selftests: Prepare dma-buf tests for obj->mm.lock removal.
838e19e54fcc drm/i915/selftests: Prepare execbuf tests for obj->mm.lock removal.
193e5ef6071e drm/i915/selftests: Prepare mman testcases for obj->mm.lock removal.
89b67cb41094 drm/i915/selftests: Prepare object tests for obj->mm.lock removal.
be7a7ff76868 drm/i915/selftests: Prepare object blit tests for obj->mm.lock removal.
4baf3a5f63b4 drm/i915/selftests: Prepare igt_gem_utils for obj->mm.lock removal
534b5384e190 drm/i915/selftests: Prepare context selftest for obj->mm.lock removal
62511fb7686a drm/i915/selftests: Prepare hangcheck for obj->mm.lock removal
a19efa44b824 drm/i915/selftests: Prepare execlists for obj->mm.lock removal
-:159: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#159: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:5857:
+	lrc = i915_gem_object_pin_map_unlocked(ce->state->obj,
 				      i915_coherent_map_type(engine->i915));

total: 0 errors, 0 warnings, 1 checks, 130 lines checked
8e5ca2d058d5 drm/i915/selftests: Prepare mocs tests for obj->mm.lock removal
2428c81511f7 drm/i915/selftests: Prepare ring submission for obj->mm.lock removal
4c5960a00cfb drm/i915/selftests: Prepare timeline tests for obj->mm.lock removal
86737adbce6e drm/i915/selftests: Prepare i915_request tests for obj->mm.lock removal
7eb4aaa48f43 drm/i915/selftests: Prepare memory region tests for obj->mm.lock removal
e001d0512655 drm/i915/selftests: Prepare cs engine tests for obj->mm.lock removal
5a60a1a40560 drm/i915/selftests: Prepare gtt tests for obj->mm.lock removal
f894a3001d3e drm/i915: Finally remove obj->mm.lock.
dd8198f7fc21 drm/i915: Keep userpointer bindings if seqcount is unchanged, v2.
291ba97334e6 drm/i915: Move gt_revoke() slightly