[Intel-gfx] [PATCH 000/141] Fix fall-through warnings for Clang

Edward Cree ecree.xilinx at gmail.com
Wed Nov 25 23:02:40 UTC 2020


On 24/11/2020 21:25, Kees Cook wrote:
> I still think this isn't right -- it's a case statement that runs off
> the end without an explicit flow control determination.

Proves too much — for instance
    case foo:
    case bar:
        thing;
        break;
 doesn't require a fallthrough; after case foo:, and afaik
 no-one is suggesting it should.  Yet it, too, is "a case
 statement that runs off the end without an explicit flow
 control determination".

-ed


More information about the Intel-gfx mailing list