[Intel-gfx] [PATCH] Memory leak fix

Steve Hampson steven.t.hampson at intel.com
Fri Oct 2 04:52:15 UTC 2020


Static analysis detected a memory leak if the second kmalloc fails
and the first allocation is not freed.

Signed-off-by: Steve Hampson <steven.t.hampson at intel.com>
---
 drivers/gpu/drm/i915/gem/i915_gem_userptr.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
index 12b30075134a..c8be7534a2fb 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_userptr.c
@@ -234,8 +234,10 @@ i915_gem_userptr_init__mmu_notifier(struct drm_i915_gem_object *obj,
 		return PTR_ERR(mn);
 
 	mo = kzalloc(sizeof(*mo), GFP_KERNEL);
-	if (!mo)
+	if (!mo) {
+		kfree(mn);
 		return -ENOMEM;
+	}
 
 	mo->mn = mn;
 	mo->obj = obj;
-- 
2.21.0



More information about the Intel-gfx mailing list