[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/jsl: Update JSL Voltage swing table

[Patchwork]

== Series Details ==

Series: drm/i915/jsl: Update JSL Voltage swing table
URL   : https://patchwork.freedesktop.org/series/82386/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
0d2e2bc8cea7 drm/i915/jsl: Split EHL/JSL platform info and PCI ids
-:163: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pll->info->id == DPLL_ID_EHL_DPLL4'
#163: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:155:
+	if (IS_JSL_EHL(i915) && (pll->info->id == DPLL_ID_EHL_DPLL4))

-:276: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects?
#276: FILE: drivers/gpu/drm/i915/i915_drv.h:1422:
+#define IS_JSL_EHL(dev_priv)	(IS_JASPERLAKE(dev_priv) || \
+				IS_ELKHARTLAKE(dev_priv))

-:287: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects?
#287: FILE: drivers/gpu/drm/i915/i915_drv.h:1564:
+#define IS_JSL_EHL_REVID(p, since, until) \
+	(IS_JSL_EHL(p) && IS_REVID(p, since, until))

-:377: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#377: FILE: include/drm/i915_pciids.h:592:
+#define INTEL_JSL_IDS(info) \
+	INTEL_VGA_DEVICE(0x4E71, info), \
 	INTEL_VGA_DEVICE(0x4E61, info), \
 	INTEL_VGA_DEVICE(0x4E57, info), \
 	INTEL_VGA_DEVICE(0x4E55, info), \

-:377: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'info' - possible side-effects?
#377: FILE: include/drm/i915_pciids.h:592:
+#define INTEL_JSL_IDS(info) \
+	INTEL_VGA_DEVICE(0x4E71, info), \
 	INTEL_VGA_DEVICE(0x4E61, info), \
 	INTEL_VGA_DEVICE(0x4E57, info), \
 	INTEL_VGA_DEVICE(0x4E55, info), \

total: 1 errors, 0 warnings, 4 checks, 269 lines checked
fc458df5554c drm/i915/edp/jsl: Update vswing table for HBR and HBR2
-:101: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#101: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:1227:
+			return jsl_combo_phy_ddi_translations_edp_hbr2;
+		} else {

total: 0 errors, 1 warnings, 0 checks, 141 lines checked