[Intel-gfx] [PATCH 03/20] drm/i915: Add PORT_TCn aliases to enum port

[Ville Syrjälä]

On Wed, Oct 07, 2020 at 03:28:48PM -0700, Lucas De Marchi wrote:
> On Tue, Oct 06, 2020 at 05:33:32PM +0300, Ville Syrjälä wrote:
> >diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
> >index 8c93253cbd95..a39be3c9e0cf 100644
> >--- a/drivers/gpu/drm/i915/display/intel_display.h
> >+++ b/drivers/gpu/drm/i915/display/intel_display.h
> >@@ -207,6 +207,14 @@ enum port {
> > 	PORT_H,
> > 	PORT_I,
> >
> >+	/* tgl+ */
> >+	PORT_TC1 = PORT_D,
> 
> ICL also uses TC ports but there PORT_TC1 would be PORT_C. Just ignore
> that and only add the aliases for tgl+ or should we also add for ICL to
> avoid confusion?

The spec still uses the DDI C-F names on icl for the TC DDIs.
My idea here is to match the spec terminology.

However, it's going to get annoying in the future because some
of the TC DDIs revert back to alphabetic names in the future,
and in a way that doesn't match the original alphabetic names.
Not quite sure how to deal with that. Probably more aliases,
but this time with a platform specific suffix :(

> 
> Lucas De Marchi
> 
> >+	PORT_TC2,
> >+	PORT_TC3,
> >+	PORT_TC4,
> >+	PORT_TC5,
> >+	PORT_TC6,
> >+
> > 	I915_MAX_PORTS
> > };
> >
> >-- 
> >2.26.2
> >
> >_______________________________________________
> >Intel-gfx mailing list
> >Intel-gfx at lists.freedesktop.org
> >https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel