[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Remove obj->mm.lock! (rev8)

[Patchwork]

== Series Details ==

Series: drm/i915: Remove obj->mm.lock! (rev8)
URL   : https://patchwork.freedesktop.org/series/82337/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
d212e6113fa5 drm/i915: Move cmd parser pinning to execbuffer
21b445301cb6 drm/i915: Add missing -EDEADLK handling to execbuf pinning
-:47: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#47: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:452:
+		err = i915_vma_pin_ww(vma, &eb->ww,
 					     entry->pad_to_size,

total: 0 errors, 0 warnings, 1 checks, 54 lines checked
4249400a8848 drm/i915: Do not share hwsp across contexts any more, v4.
-:516: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#516: FILE: drivers/gpu/drm/i915/gt/intel_timeline.c:296:
+	if (tl && (i915_request_completed(from) ||
+	    !i915_active_acquire_if_busy(&tl->active)))

total: 0 errors, 0 warnings, 1 checks, 623 lines checked
da03a901bab6 drm/i915: Pin timeline map after first timeline pin, v3.
-:13: WARNING:TYPO_SPELLING: 'arithmatic' may be misspelled - perhaps 'arithmetic'?
#13: 
- Fix NULL + XX arithmatic, use casts. (kbuild)

total: 0 errors, 1 warnings, 0 checks, 295 lines checked
8ee2dbc32daf drm/i915: Ensure we hold the object mutex in pin correctly.
e24f84e20fbf drm/i915: Add gem object locking to madvise.
48f2325f6009 drm/i915: Move HAS_STRUCT_PAGE to obj->flags
-:106: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#106: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.c:63:
+			  struct lock_class_key *key, unsigned flags)

-:129: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#129: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:27:
+			  unsigned alloc_flags);

total: 0 errors, 2 warnings, 0 checks, 348 lines checked
da50a22c2c73 drm/i915: Rework struct phys attachment handling
f956c0fbb9a5 drm/i915: Convert i915_gem_object_attach_phys() to ww locking
f36602118f4e drm/i915: make lockdep slightly happier about execbuf.
5585b6565924 drm/i915: Disable userptr pread/pwrite support.
9f1d8101a0ee drm/i915: No longer allow exporting userptr through dma-buf
e7436f5f1e77 drm/i915: Reject more ioctls for userptr
-:7: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#7: 
set_tiling and set_caching are rejected with -ENXIO, there's no valid reason

total: 0 errors, 1 warnings, 0 checks, 39 lines checked
f75d81ecd524 drm/i915: Reject UNSYNCHRONIZED for userptr
e7e0452508da drm/i915: Fix userptr so we do not have to worry about obj->mm.lock, v4.
-:280: WARNING:LONG_LINE: line length of 121 exceeds 100 columns
#280: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:555:
+static inline int i915_gem_object_userptr_submit_init(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); return -ENODEV; }

-:281: WARNING:LONG_LINE: line length of 121 exceeds 100 columns
#281: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:556:
+static inline int i915_gem_object_userptr_submit_done(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); return -ENODEV; }

-:282: WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#282: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:557:
+static inline void i915_gem_object_userptr_submit_fini(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); }

-:340: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#340: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:2:
  * SPDX-License-Identifier: MIT

-:344: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#344: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:6:
+ *
+  * Based on amdgpu_mn, which bears the following notice:

-:345: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#345: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:7:
+  * Based on amdgpu_mn, which bears the following notice:
+ *

-:492: WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#492: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:63:
+	struct drm_i915_gem_object *obj = container_of(mni, struct drm_i915_gem_object, userptr.notifier);

-:1110: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#1110: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:287:
+	pinned = ret = 0;

-:1125: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1125: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:302:
+	if (mmu_interval_read_retry(&obj->userptr.notifier,
+		!obj->userptr.page_ref ? notifier_seq :

-:1246: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#1246: FILE: drivers/gpu/drm/i915/i915_drv.h:597:
+	spinlock_t notifier_lock;

total: 0 errors, 7 warnings, 3 checks, 1193 lines checked
7fd2b6345736 drm/i915: Flatten obj->mm.lock
e5804c66e752 drm/i915: Populate logical context during first pin.
-:176: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#176: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:5531:
+virtual_context_pre_pin(struct intel_context *ce,
+			  struct i915_gem_ww_ctx *ww, void **vaddr)

total: 0 errors, 0 warnings, 1 checks, 169 lines checked
ad1d55f3d681 drm/i915: Make ring submission compatible with obj->mm.lock removal, v2.
0f29eae64a65 drm/i915: Handle ww locking in init_status_page
af50fa854941 drm/i915: Rework clflush to work correctly without obj->mm.lock.
8056e2444996 drm/i915: Pass ww ctx to intel_pin_to_display_plane
2284d6c7118a drm/i915: Add object locking to vm_fault_cpu
41aa20ceb70b drm/i915: Move pinning to inside engine_wa_list_verify()
-:53: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#53: FILE: drivers/gpu/drm/i915/gt/intel_workarounds.c:2207:
+	err = i915_vma_pin_ww(vma, &ww, 0, 0,
+			   i915_vma_is_ggtt(vma) ? PIN_GLOBAL : PIN_USER);

total: 0 errors, 0 warnings, 1 checks, 109 lines checked
d71ea3e23ad6 drm/i915: Take reservation lock around i915_vma_pin.
4a0da901373f drm/i915: Make intel_init_workaround_bb more compatible with ww locking.
375d99b1d2a7 drm/i915: Make __engine_unpark() compatible with ww locking.
fa371fc40513 drm/i915: Take obj lock around set_domain ioctl
b60941c28bf3 drm/i915: Defer pin calls in buffer pool until first use by caller.
7c1606d6d299 drm/i915: Fix pread/pwrite to work with new locking rules.
-:28: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
deleted file mode 100644

total: 0 errors, 1 warnings, 0 checks, 401 lines checked
d87e52aa55b4 drm/i915: Fix workarounds selftest, part 1
e1688dc7479a drm/i915: Prepare for obj->mm.lock removal
-:131: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author '"Thomas Hellström" <thomas.hellstrom at intel.com>'

total: 0 errors, 1 warnings, 0 checks, 96 lines checked
2b6c123ed361 drm/i915: Add igt_spinner_pin() to allow for ww locking around spinner.
e9907b3ca3a5 drm/i915: Add ww locking around vm_access()
01bc5a20d4f2 drm/i915: Increase ww locking for perf.
6f091934cfd0 drm/i915: Lock ww in ucode objects correctly
2bd379ce7284 drm/i915: Add ww locking to dma-buf ops.
4274adf91b06 drm/i915: Add missing ww lock in intel_dsb_prepare.
20f3947c7354 drm/i915: Fix ww locking in shmem_create_from_object
ad12e91272ba drm/i915: Use a single page table lock for each gtt.
-:108: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#108: FILE: drivers/gpu/drm/i915/gt/intel_gtt.c:85:
+		return i915_gem_object_lock(vm->scratch[0], ww);
+	} else {

total: 0 errors, 1 warnings, 0 checks, 154 lines checked
24b1c124b686 drm/i915/selftests: Prepare huge_pages testcases for obj->mm.lock removal.
d5c76890a59f drm/i915/selftests: Prepare client blit for obj->mm.lock removal.
8f889023ba33 drm/i915/selftests: Prepare coherency tests for obj->mm.lock removal.
30a7e27e4635 drm/i915/selftests: Prepare context tests for obj->mm.lock removal.
a1c9cf68da1c drm/i915/selftests: Prepare dma-buf tests for obj->mm.lock removal.
801e1661833a drm/i915/selftests: Prepare execbuf tests for obj->mm.lock removal.
bc6c558d584d drm/i915/selftests: Prepare mman testcases for obj->mm.lock removal.
588f4f5e3fa8 drm/i915/selftests: Prepare object tests for obj->mm.lock removal.
4f28302eb1e3 drm/i915/selftests: Prepare object blit tests for obj->mm.lock removal.
57130374dc6f drm/i915/selftests: Prepare igt_gem_utils for obj->mm.lock removal
e5f8dc58cdb9 drm/i915/selftests: Prepare context selftest for obj->mm.lock removal
8322d3111639 drm/i915/selftests: Prepare hangcheck for obj->mm.lock removal
a716081fe319 drm/i915/selftests: Prepare execlists for obj->mm.lock removal
-:155: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#155: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:5857:
+	lrc = i915_gem_object_pin_map_unlocked(ce->state->obj,
 				      i915_coherent_map_type(engine->i915));

total: 0 errors, 0 warnings, 1 checks, 130 lines checked
860a68a819eb drm/i915/selftests: Prepare mocs tests for obj->mm.lock removal
0da28f9bb622 drm/i915/selftests: Prepare ring submission for obj->mm.lock removal
8ab46a5b4335 drm/i915/selftests: Prepare timeline tests for obj->mm.lock removal
b5e1a5c015e7 drm/i915/selftests: Prepare i915_request tests for obj->mm.lock removal
f4937b0df49d drm/i915/selftests: Prepare memory region tests for obj->mm.lock removal
2769b22737e3 drm/i915/selftests: Prepare cs engine tests for obj->mm.lock removal
733919ef0b66 drm/i915/selftests: Prepare gtt tests for obj->mm.lock removal
908f14a92e4a drm/i915: Finally remove obj->mm.lock.
8f716caa264e drm/i915: Keep userpointer bindings if seqcount is unchanged, v2.