[Intel-gfx] [PATCH 1/2] drm/i915: Reject 90/270 degree rotated initial fbs

Ville Syrjala ville.syrjala at linux.intel.com
Tue Oct 20 19:43:29 UTC 2020


From: Ville Syrjälä <ville.syrjala at linux.intel.com>

We don't currently handle the initial fb readout correctly
for 90/270 degree rotated scanout. Reject it.

Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 60bacdbe7f92..fd0103f6cc95 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -10696,6 +10696,10 @@ skl_get_initial_plane_config(struct intel_crtc *crtc,
 	    val & PLANE_CTL_FLIP_HORIZONTAL)
 		plane_config->rotation |= DRM_MODE_REFLECT_X;
 
+	/* 90/270 degree rotation would require extra work */
+	if (drm_rotation_90_or_270(plane_config->rotation))
+		goto error;
+
 	base = intel_de_read(dev_priv, PLANE_SURF(pipe, plane_id)) & 0xfffff000;
 	plane_config->base = base;
 
-- 
2.26.2



More information about the Intel-gfx mailing list