[Intel-gfx] [PATCH] drm/i915/display: Unkerneldoc cnl_program_nearest_filter_coefs

[Ville Syrjälä]

On Wed, Oct 21, 2020 at 07:56:49PM +0100, Chris Wilson wrote:
> The block comment for cnl_program_nearest_filter_coefs() has a wonderful
> diagram, but although it is marked up as kerneldoc does not use the
> markup for providing the function definition.
> 
> drivers/gpu/drm/i915/display/intel_display.c:6341: warning: Function parameter or member 'dev_priv' not described in 'cnl_program_nearest_filter_coefs'
> drivers/gpu/drm/i915/display/intel_display.c:6341: warning: Function parameter or member 'pipe' not described in 'cnl_program_nearest_filter_coefs'
> drivers/gpu/drm/i915/display/intel_display.c:6341: warning: Function parameter or member 'id' not described in 'cnl_program_nearest_filter_coefs'
> drivers/gpu/drm/i915/display/intel_display.c:6341: warning: Function parameter or member 'set' not described in 'cnl_program_nearest_filter_coefs'
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 130303e0298a..6eff9a971d0b 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -6299,7 +6299,7 @@ static u16 cnl_nearest_filter_coef(int t)
>  	return t == 3 ? 0x0800 : 0x3000;
>  }
>  
> -/**
> +/*
>   *  Theory behind setting nearest-neighbor integer scaling:
>   *
>   *  17 phase of 7 taps requires 119 coefficients in 60 dwords per set.
> -- 
> 2.20.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel