[Intel-gfx] [PATCH v11 08/12] drm/i915/dp: Master/Slave enable/disable sequence for bigjoiner
Dan Carpenter
dan.carpenter at oracle.com
Fri Oct 23 07:57:37 UTC 2020
Hi Manasi,
url: https://github.com/0day-ci/linux/commits/Manasi-Navare/Big-joiner-enabling/20201022-134216
base: git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: x86_64-randconfig-m001-20201022 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>
Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
New smatch warnings:
drivers/gpu/drm/i915/display/intel_display.c:7303 hsw_crtc_enable() warn: if statement not indented
Old smatch warnings:
drivers/gpu/drm/i915/display/intel_display.c:6237 skl_update_scaler_plane() error: we previously assumed 'fb' could be null (see line 6221)
drivers/gpu/drm/i915/display/intel_display.c:15236 kill_bigjoiner_slave() warn: inconsistent indenting
vim +7303 drivers/gpu/drm/i915/display/intel_display.c
1e98f88cea0ff5 drivers/gpu/drm/i915/display/intel_display.c Lucas De Marchi 2019-12-24 7274 static void hsw_crtc_enable(struct intel_atomic_state *state,
7451a074bf2f26 drivers/gpu/drm/i915/display/intel_display.c Ville Syrjälä 2019-11-18 7275 struct intel_crtc *crtc)
6be4a6078e41a8 drivers/gpu/drm/i915/intel_display.c Jesse Barnes 2010-09-10 7276 {
7451a074bf2f26 drivers/gpu/drm/i915/display/intel_display.c Ville Syrjälä 2019-11-18 7277 const struct intel_crtc_state *new_crtc_state =
7451a074bf2f26 drivers/gpu/drm/i915/display/intel_display.c Ville Syrjälä 2019-11-18 7278 intel_atomic_get_new_crtc_state(state, crtc);
e44c84a14469d3 drivers/gpu/drm/i915/display/intel_display.c Ville Syrjälä 2019-11-18 7279 struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
e44c84a14469d3 drivers/gpu/drm/i915/display/intel_display.c Ville Syrjälä 2019-11-18 7280 enum pipe pipe = crtc->pipe, hsw_workaround_pipe;
502d871459d25e drivers/gpu/drm/i915/display/intel_display.c Ville Syrjälä 2019-11-18 7281 enum transcoder cpu_transcoder = new_crtc_state->cpu_transcoder;
ed69cd40685c94 drivers/gpu/drm/i915/intel_display.c Imre Deak 2017-10-02 7282 bool psl_clkgate_wa;
2c07245fb8f7f0 drivers/gpu/drm/i915/intel_display.c Zhenyu Wang 2009-06-05 7283
e57291c2d39522 drivers/gpu/drm/i915/display/intel_display.c Pankaj Bharadiya 2020-02-20 7284 if (drm_WARN_ON(&dev_priv->drm, crtc->active))
f7abfe8b281991 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2010-09-13 7285 return;
f7abfe8b281991 drivers/gpu/drm/i915/intel_display.c Chris Wilson 2010-09-13 7286
9587d0b839b5fd drivers/gpu/drm/i915/display/intel_display.c Manasi Navare 2020-10-21 7287 if (!new_crtc_state->bigjoiner) {
e44c84a14469d3 drivers/gpu/drm/i915/display/intel_display.c Ville Syrjälä 2019-11-18 7288 intel_encoders_pre_pll_enable(state, crtc);
95a7a2ae46652f drivers/gpu/drm/i915/intel_display.c Imre Deak 2016-06-13 7289
502d871459d25e drivers/gpu/drm/i915/display/intel_display.c Ville Syrjälä 2019-11-18 7290 if (new_crtc_state->shared_dpll)
502d871459d25e drivers/gpu/drm/i915/display/intel_display.c Ville Syrjälä 2019-11-18 7291 intel_enable_shared_dpll(new_crtc_state);
df8ad70ca34f9b drivers/gpu/drm/i915/intel_display.c Daniel Vetter 2014-06-25 7292
e44c84a14469d3 drivers/gpu/drm/i915/display/intel_display.c Ville Syrjälä 2019-11-18 7293 intel_encoders_pre_enable(state, crtc);
9587d0b839b5fd drivers/gpu/drm/i915/display/intel_display.c Manasi Navare 2020-10-21 7294 } else {
9587d0b839b5fd drivers/gpu/drm/i915/display/intel_display.c Manasi Navare 2020-10-21 7295 icl_ddi_bigjoiner_pre_enable(state, new_crtc_state);
9587d0b839b5fd drivers/gpu/drm/i915/display/intel_display.c Manasi Navare 2020-10-21 7296 }
9587d0b839b5fd drivers/gpu/drm/i915/display/intel_display.c Manasi Navare 2020-10-21 7297
9587d0b839b5fd drivers/gpu/drm/i915/display/intel_display.c Manasi Navare 2020-10-21 7298 intel_set_pipe_src_size(new_crtc_state);
9587d0b839b5fd drivers/gpu/drm/i915/display/intel_display.c Manasi Navare 2020-10-21 7299 if (INTEL_GEN(dev_priv) >= 9 || IS_BROADWELL(dev_priv))
9587d0b839b5fd drivers/gpu/drm/i915/display/intel_display.c Manasi Navare 2020-10-21 7300 bdw_set_pipemisc(new_crtc_state);
c8af5274c3cbac drivers/gpu/drm/i915/intel_display.c Paulo Zanoni 2018-05-02 7301
9587d0b839b5fd drivers/gpu/drm/i915/display/intel_display.c Manasi Navare 2020-10-21 7302 if (!new_crtc_state->bigjoiner_slave || !transcoder_is_dsi(cpu_transcoder)){
d7edc4e57bfefc drivers/gpu/drm/i915/intel_display.c Ville Syrjälä 2016-06-22 @7303 if (!transcoder_is_dsi(cpu_transcoder))
e7fc3f902d76f1 drivers/gpu/drm/i915/display/intel_display.c Manasi Navare 2020-10-08 7304 intel_set_transcoder_timings(new_crtc_state);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
This looks correct, only the indenting is wrong.
4d1de975683218 drivers/gpu/drm/i915/intel_display.c Jani Nikula 2016-03-18 7305
4d1de975683218 drivers/gpu/drm/i915/intel_display.c Jani Nikula 2016-03-18 7306 if (cpu_transcoder != TRANSCODER_EDP &&
502d871459d25e drivers/gpu/drm/i915/display/intel_display.c Ville Syrjälä 2019-11-18 7307 !transcoder_is_dsi(cpu_transcoder))
dc008bf0aa091c drivers/gpu/drm/i915/display/intel_display.c Jani Nikula 2020-01-27 7308 intel_de_write(dev_priv, PIPE_MULT(cpu_transcoder),
502d871459d25e drivers/gpu/drm/i915/display/intel_display.c Ville Syrjälä 2019-11-18 7309 new_crtc_state->pixel_multiplier - 1);
ebb69c95175609 drivers/gpu/drm/i915/intel_display.c Clint Taylor 2014-09-30 7310
502d871459d25e drivers/gpu/drm/i915/display/intel_display.c Ville Syrjälä 2019-11-18 7311 if (new_crtc_state->has_pch_encoder)
502d871459d25e drivers/gpu/drm/i915/display/intel_display.c Ville Syrjälä 2019-11-18 7312 intel_cpu_transcoder_set_m_n(new_crtc_state,
502d871459d25e drivers/gpu/drm/i915/display/intel_display.c Ville Syrjälä 2019-11-18 7313 &new_crtc_state->fdi_m_n, NULL);
229fca97437310 drivers/gpu/drm/i915/intel_display.c Daniel Vetter 2014-04-24 7314
502d871459d25e drivers/gpu/drm/i915/display/intel_display.c Ville Syrjälä 2019-11-18 7315 hsw_set_frame_start_delay(new_crtc_state);
cc7a4cffea2195 drivers/gpu/drm/i915/display/intel_display.c Ville Syrjälä 2019-10-24 7316 }
4d1de975683218 drivers/gpu/drm/i915/intel_display.c Jani Nikula 2016-03-18 7317
9587d0b839b5fd drivers/gpu/drm/i915/display/intel_display.c Manasi Navare 2020-10-21 7318 if (!transcoder_is_dsi(cpu_transcoder))
9587d0b839b5fd drivers/gpu/drm/i915/display/intel_display.c Manasi Navare 2020-10-21 7319 hsw_set_pipeconf(new_crtc_state);
229fca97437310 drivers/gpu/drm/i915/intel_display.c Daniel Vetter 2014-04-24 7320
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 36113 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20201023/7cb4faec/attachment-0001.gz>
More information about the Intel-gfx
mailing list