[Intel-gfx] [PATCH 2/3] drm/vc4: Drop legacy_cursor_update override

Daniel Vetter daniel.vetter at ffwll.ch
Fri Oct 23 12:39:24 UTC 2020


With the removal of helper support it doesn't do anything anymore.
Also, we already have async plane update code in vc4.

Acked-by: Maxime Ripard <mripard at kernel.org>
Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
Cc: Eric Anholt <eric at anholt.net>
Cc: Maxime Ripard <mripard at kernel.org>
---
 drivers/gpu/drm/vc4/vc4_kms.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/gpu/drm/vc4/vc4_kms.c
index 149825ff5df8..bf0da77ab2e6 100644
--- a/drivers/gpu/drm/vc4/vc4_kms.c
+++ b/drivers/gpu/drm/vc4/vc4_kms.c
@@ -353,12 +353,6 @@ static int vc4_atomic_commit(struct drm_device *dev,
 		return 0;
 	}
 
-	/* We know for sure we don't want an async update here. Set
-	 * state->legacy_cursor_update to false to prevent
-	 * drm_atomic_helper_setup_commit() from auto-completing
-	 * commit->flip_done.
-	 */
-	state->legacy_cursor_update = false;
 	ret = drm_atomic_helper_setup_commit(state, nonblock);
 	if (ret)
 		return ret;
-- 
2.28.0



More information about the Intel-gfx mailing list