[Intel-gfx] [PATCH v3 03/16] drm/i915/hotplug: Handle CP_IRQ for DP-MST

[Shankar, Uma]

> -----Original Message-----
> From: Anshuman Gupta <anshuman.gupta at intel.com>
> Sent: Friday, October 23, 2020 5:51 PM
> To: intel-gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org
> Cc: seanpaul at chromium.org; Nikula, Jani <jani.nikula at intel.com>; C,
> Ramalingam <ramalingam.c at intel.com>; Li, Juston <juston.li at intel.com>;
> Shankar, Uma <uma.shankar at intel.com>; Gupta, Anshuman
> <anshuman.gupta at intel.com>; Ville Syrjälä <ville.syrjala at linux.intel.com>
> Subject: [PATCH v3 03/16] drm/i915/hotplug: Handle CP_IRQ for DP-MST
> 
> Handle CP_IRQ in DEVICE_SERVICE_IRQ_VECTOR_ESI0 It requires to call
> intel_hdcp_handle_cp_irq() in case of CP_IRQ is triggered by a sink in DP-MST
> topology.

Looks Good to me.
Reviewed-by: Uma Shankar <uma.shankar at intel.com>

> Cc: "Ville Syrjälä" <ville.syrjala at linux.intel.com>
> Cc: Ramalingam C <ramalingam.c at intel.com>
> Signed-off-by: Anshuman Gupta <anshuman.gupta at intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_dp.c | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
> b/drivers/gpu/drm/i915/display/intel_dp.c
> index 818daab252f3..21c6c9828cd7 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -5657,6 +5657,17 @@ static void intel_dp_handle_test_request(struct
> intel_dp *intel_dp)
>  			    "Could not write test response to sink\n");  }
> 
> +static void
> +intel_dp_mst_hpd_irq(struct intel_dp *intel_dp, u8 *esi, bool *handled)
> +{
> +		drm_dp_mst_hpd_irq(&intel_dp->mst_mgr, esi, handled);
> +
> +		if (esi[1] & DP_CP_IRQ) {
> +			intel_hdcp_handle_cp_irq(intel_dp-
> >attached_connector);
> +			*handled = true;
> +		}
> +}
> +
>  /**
>   * intel_dp_check_mst_status - service any pending MST interrupts, check link
> status
>   * @intel_dp: Intel DP struct
> @@ -5701,7 +5712,8 @@ intel_dp_check_mst_status(struct intel_dp *intel_dp)
> 
>  		drm_dbg_kms(&i915->drm, "got esi %3ph\n", esi);
> 
> -		drm_dp_mst_hpd_irq(&intel_dp->mst_mgr, esi, &handled);
> +		intel_dp_mst_hpd_irq(intel_dp, esi, &handled);
> +
>  		if (!handled)
>  			break;
> 
> --
> 2.26.2