[Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection

[Vivi, Rodrigo]

> On Oct 27, 2020, at 11:49 PM, Pandey, Hariom <hariom.pandey at intel.com> wrote:
> 
> Hi Chris,
>  
> Awaiting your kind response here…

https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9208/fi-ehl-1/igt@i915_selftest@live@gt_pm.html
"Did not enter RC6!"

Chris already told that we need to get RC6 working on CI.
If we need BIOS update or machine replacement there we need to work with CI team to make that happen.

>  
> Thanks
> Hariom Pandey
>  
> From: Pandey, Hariom 
> Sent: Tuesday, October 20, 2020 9:28 PM
> To: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Ausmus, James <james.ausmus at intel.com>; Nikula, Jani <jani.nikula at intel.com>; intel-gfx@ <lists.freedesktop.org intel-gfx at lists.freedesktop.org>; Souza, Jose <jose.souza at intel.com>; dri-devel@ <lists.freedesktop.org dri-devel at lists.freedesktop.org>; Surendrakumar Upadhyay, TejaskumarX <tejaskumarx.surendrakumar.upadhyay at intel.com>; K, SrinivasX <srinivasx.k at intel.com>; Vivi, Rodrigo <rodrigo.vivi at intel.com>; Meena, Mahesh <Mahesh.Meena at intel.com>
> Subject: RE: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe protection
>  
> Hi Chris,
>  
> We have run RC6 test cases as recently as 4 days ago on EHL and they have passed. Below are the pass log links & attached email has the DRM/IGT tag where they have passed. We are finding that the “EHL BAT setup” is not upto date in terms of Silicon & BIOS which we are working to upgrade. But just for that, should we block this patch? Just trying to understand as there is no inherent or latent RC6 issue anymore.
>  
> 	• igt at i915_pm_rc6_residency@rc6-accuracy --- PASS - Log
> 	• igt at i915_pm_rc6_residency@rc6-fence --- PASS – Log
> 	• igt at i915_pm_rc6_residency@rc6-idle --- PASS - Log
> 	• igt at perf@rc6-disable --- PASS - Log
> 	• igt at perf_pmu@rc6 --- PASS - Log
> 	• igt at perf_pmu@rc6-runtime-pm --- PASS - Log
> 	• igt at perf_pmu@rc6-runtime-pm-long --- PASS – Log
>  
>  
> Thanks
> Hariom Pandey
>  
> > -----Original Message-----
> > From: Chris Wilson <chris at chris-wilson.co.uk>
> > Sent: Tuesday, October 20, 2020 12:04 AM
> > To: K, SrinivasX <srinivasx.k at intel.com>; Vivi, Rodrigo
> > <rodrigo.vivi at intel.com>
> > Cc: Pandey, Hariom <hariom.pandey at intel.com>; Ausmus, James
> > <james.ausmus at intel.com>; Nikula, Jani <jani.nikula at intel.com>; intel-gfx@
> > <lists.freedesktop.org intel-gfx at lists.freedesktop.org>; Souza, Jose
> > <jose.souza at intel.com>; dri-devel@ <lists.freedesktop.org dri-
> > devel at lists.freedesktop.org>; Surendrakumar Upadhyay, TejaskumarX
> > <tejaskumarx.surendrakumar.upadhyay at intel.com>
> > Subject: Re: [Intel-gfx] [PATCH] drm/i915/ehl: Remove require_force_probe
> > protection
> > 
> > Quoting Rodrigo Vivi (2020-10-19 19:29:36)
> > >
> > > I just checked the CI picture and it looks much better indeed.
> > >
> > > Only bad case being the gt_pm, which is also failing on other platforms.
> > 
> > Not nearly in the same manner. CI is indicating that there is no RC6 entry and
> > no power saving at all; neither in the selftests nor visible from userspace.
> > That is a critical battery eating bug.
> > 
> > If there's a patch to fix it for ehl and jsl, send it to CI for proving.
> > -Chris
> <Mail Attachment.eml>