[Intel-gfx] [PATCH v4 13/61] drm/i915: Reject more ioctls for userptr

Thomas Hellström (Intel) thomas_os at shipmail.org
Fri Oct 30 14:14:20 UTC 2020


Hi, Maarten,

On 10/30/20 10:56 AM, Maarten Lankhorst wrote:
> Op 30-10-2020 om 10:22 schreef Thomas Hellström (Intel):
>> On 10/16/20 12:43 PM, Maarten Lankhorst wrote:
>>> Allow set_domain to fail silently, waiting for idle should be good enough.
>>> set_tiling and set_caching are rejected with -ENXIO, there's no valid reason
>>> to allow it.
>> Please list all affected ioctls affected by the IS_PROXY flag. We also need userspace maintainer acks for this.
> set_caching, set_domain and set_tiling. set_domain turns into a gem_wait for coherent userptr, since the other ioctl's that affect placement and caching are no longer allowed. :)

Sounds fine. The comment was about adding to the commit message.


> ~Maarten
>
>>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>


More information about the Intel-gfx mailing list