[Intel-gfx] [PATCH v4 14/61] drm/i915: Reject UNSYNCHRONIZED for userptr

Thomas Hellström (Intel) thomas_os at shipmail.org
Fri Oct 30 14:15:56 UTC 2020


On 10/30/20 11:10 AM, Maarten Lankhorst wrote:
> Op 30-10-2020 om 10:26 schreef Thomas Hellström (Intel):
>> On 10/16/20 12:43 PM, Maarten Lankhorst wrote:
>>> We should not allow this any more, as it will break with the new userptr
>>> implementation, it could still be made to work, but there's no point in
>>> doing so.
>>>
>>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
>> Ifdefs don't appear consistent with the commit message. Wrong patch or separate patch?
>>
>> Also please add a discussion what impact this has on existing user-space.
>>
>>
> Impact should be low, xf86-video-intel with SNA was using unsynchronized, but will fall back to synchronized if not available.

Sounds ok to me if that's the only impact. Also here the review comment 
was about adding to the commit message.




More information about the Intel-gfx mailing list