[Intel-gfx] [PATCH v4 14/61] drm/i915: Reject UNSYNCHRONIZED for userptr

Thomas Hellström (Intel) thomas_os at shipmail.org
Fri Oct 30 14:18:31 UTC 2020


On 10/30/20 11:11 AM, Maarten Lankhorst wrote:
> Op 30-10-2020 om 10:26 schreef Thomas Hellström (Intel):
>> On 10/16/20 12:43 PM, Maarten Lankhorst wrote:
>>> We should not allow this any more, as it will break with the new userptr
>>> implementation, it could still be made to work, but there's no point in
>>> doing so.
>>>
>>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
>> Ifdefs don't appear consistent with the commit message. Wrong patch or separate patch?
>>
>> Also please add a discussion what impact this has on existing user-space.
>>
>>
> Regarding ifdefs, all the userptr codeis unused when mmu notifers are not available, so I made it conditional on that.

Yes I have nothing against the cange itself. But this is a fixup change 
that has nothing to do with rejecting UNSYNCHRONIZED and thus it should 
be moved to a separate commit or perhaps squashed in the big userptr 
rewrite?

/Thomas




More information about the Intel-gfx mailing list